All of lore.kernel.org
 help / color / mirror / Atom feed
From: Anthony Liguori <aliguori@redhat.com>
To: Markus Armbruster <armbru@redhat.com>
Cc: Mark McLoughlin <markmc@redhat.com>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 1/6] net: Remove unused net_client_uninit()
Date: Fri, 19 Feb 2010 14:55:37 -0600	[thread overview]
Message-ID: <4B7EFAC9.8010104@redhat.com> (raw)
In-Reply-To: <1265895902-15664-2-git-send-email-armbru@redhat.com>

On 02/11/2010 07:44 AM, Markus Armbruster wrote:
> Unused since commit 9ad4531e.
>
> Signed-off-by: Markus Armbruster<armbru@redhat.com>
>    

Applied all.  Thanks.

Regards,

Anthony Liguori

> ---
>   net.c |   14 --------------
>   net.h |    1 -
>   2 files changed, 0 insertions(+), 15 deletions(-)
>
> diff --git a/net.c b/net.c
> index 8e951ca..f51d376 100644
> --- a/net.c
> +++ b/net.c
> @@ -1128,20 +1128,6 @@ int net_client_init(Monitor *mon, QemuOpts *opts, int is_netdev)
>       return -1;
>   }
>
> -void net_client_uninit(NICInfo *nd)
> -{
> -    if (nd->vlan) {
> -        nd->vlan->nb_guest_devs--;
> -    }
> -    nb_nics--;
> -
> -    qemu_free(nd->model);
> -    qemu_free(nd->name);
> -    qemu_free(nd->devaddr);
> -
> -    nd->used = 0;
> -}
> -
>   static int net_host_check_device(const char *device)
>   {
>       int i;
> diff --git a/net.h b/net.h
> index 116bb80..ecbd812 100644
> --- a/net.h
> +++ b/net.h
> @@ -163,7 +163,6 @@ extern const char *legacy_tftp_prefix;
>   extern const char *legacy_bootp_filename;
>
>   int net_client_init(Monitor *mon, QemuOpts *opts, int is_netdev);
> -void net_client_uninit(NICInfo *nd);
>   int net_client_parse(QemuOptsList *opts_list, const char *str);
>   int net_init_clients(void);
>   void net_cleanup(void);
>    

  reply	other threads:[~2010-02-19 20:58 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-02-11 13:44 [Qemu-devel] [PATCH 0/6] Assorted netdev fixes Markus Armbruster
2010-02-11 13:44 ` [Qemu-devel] [PATCH 1/6] net: Remove unused net_client_uninit() Markus Armbruster
2010-02-19 20:55   ` Anthony Liguori [this message]
2010-02-19 20:55   ` Anthony Liguori
2010-02-11 13:44 ` [Qemu-devel] [PATCH 2/6] net: net_check_clients() runs too early to see -device, fix Markus Armbruster
2010-02-11 13:44 ` [Qemu-devel] [PATCH 3/6] net: Fix bogus "Warning: vlan 0 with no nics" with -device Markus Armbruster
2010-02-11 13:45 ` [Qemu-devel] [PATCH 4/6] net: net_check_clients() checks only VLAN clients, fix Markus Armbruster
2010-02-11 13:45 ` [Qemu-devel] [PATCH 5/6] net: info network shows " Markus Armbruster
2010-02-11 13:45 ` [Qemu-devel] [PATCH 6/6] net: Monitor command set_link finds " Markus Armbruster
2010-02-11 13:58 ` [Qemu-devel] Re: [PATCH 0/6] Assorted netdev fixes Mark McLoughlin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4B7EFAC9.8010104@redhat.com \
    --to=aliguori@redhat.com \
    --cc=armbru@redhat.com \
    --cc=markmc@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.