From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1NiaTR-0003Lh-D4
	for qemu-devel@nongnu.org; Fri, 19 Feb 2010 16:33:21 -0500
Received: from [199.232.76.173] (port=33286 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1NiaTH-00039e-20
	for qemu-devel@nongnu.org; Fri, 19 Feb 2010 16:33:11 -0500
Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim
	4.60) (envelope-from <anthony@codemonkey.ws>) id 1NiaTE-0003b7-VQ
	for qemu-devel@nongnu.org; Fri, 19 Feb 2010 16:33:10 -0500
Received: from mail-yw0-f197.google.com ([209.85.211.197]:57034)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <anthony@codemonkey.ws>) id 1NiaTE-0003an-JR
	for qemu-devel@nongnu.org; Fri, 19 Feb 2010 16:33:08 -0500
Received: by ywh35 with SMTP id 35so495911ywh.4
	for <qemu-devel@nongnu.org>; Fri, 19 Feb 2010 13:33:07 -0800 (PST)
Message-ID: <4B7F0390.1030206@codemonkey.ws>
Date: Fri, 19 Feb 2010 15:33:04 -0600
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH] pcnet APROMWE bit location
References: <4B78A904.9020700@whiterocker.com>
In-Reply-To: <4B78A904.9020700@whiterocker.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Chris Kilgour <techie@whiterocker.com>
Cc: qemu-devel@nongnu.org

On 02/14/2010 07:53 PM, Chris Kilgour wrote:
> I don't subscribe to the list, so please excuse any breach of etiquette.
>
> According to AMD document 21485D pp.141, APROMWE is bit 8 of BCR2.
>
> Signed-off-by: Christopher Kilgour<techie<at>  whiterocker.com>
>    

Your mailer munged this patch so it doesn't apply.  Please resend.  
Also, please use a proper email address in the Signed-off-by line.

Regards,

Anthony Liguori

> ---
>
> diff --git a/hw/pcnet.c b/hw/pcnet.c
> index 44b5b31..f889898 100644
> --- a/hw/pcnet.c
> +++ b/hw/pcnet.c
> @@ -1601,7 +1601,7 @@ static void pcnet_aprom_writeb(void *opaque,
> uint32_t addr
>       printf("pcnet_aprom_writeb addr=0x%08x val=0x%02x\n", addr, val);
>   #endif
>       /* Check APROMWE bit to enable write access */
> -    if (pcnet_bcr_readw(s,2)&  0x80)
> +    if (pcnet_bcr_readw(s,2)&  0x100)
>           s->prom[addr&  15] = val;
>   }
>
>
>
>
>