From: "René Scharfe" <rene.scharfe@lsrfire.ath.cx>
To: Git Mailing List <git@vger.kernel.org>
Cc: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Subject: [PATCH 0/4] utf8.c: strbuf'ify strbuf_add_wrapped_text()
Date: Fri, 19 Feb 2010 23:13:28 +0100 [thread overview]
Message-ID: <4B7F0D08.6040608@lsrfire.ath.cx> (raw)
The strbuf parameter of strbuf_add_wrapped_text() in utf8.c is
optional; if it's missing, results are directly written to stdout.
By removing this flexibility and converting it to only call "pure"
strbuf functions, this series cleans up the code a bit and enables
an optimization, which is added in the last patch:
[PATCH 1/4] utf8.c: remove print_wrapped_text()
[PATCH 2/4] utf8.c: remove print_spaces()
[PATCH 3/4] utf8.c: remove strbuf_write()
[PATCH 4/4] utf8.c: speculatively assume utf-8 in strbuf_add_wrapped_text()
builtin-shortlog.c | 17 ++++++++++++--
utf8.c | 61 +++++++++++++++++++++++----------------------------
utf8.h | 1 -
3 files changed, 42 insertions(+), 37 deletions(-)
next reply other threads:[~2010-02-19 22:13 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-19 22:13 René Scharfe [this message]
2010-02-19 22:15 ` [PATCH 1/4] utf8.c: remove print_wrapped_text() René Scharfe
2010-02-19 22:15 ` [PATCH 2/4] utf8.c: remove print_spaces() René Scharfe
2010-02-19 22:16 ` [PATCH 3/4] utf8.c: remove strbuf_write() René Scharfe
2010-02-19 22:20 ` [PATCH 4/4] utf8.c: speculatively assume utf-8 in strbuf_add_wrapped_text() René Scharfe
2010-02-20 9:14 ` Johannes Schindelin
2010-02-20 19:22 ` Junio C Hamano
2010-02-20 9:03 ` [PATCH 0/4] utf8.c: strbuf'ify strbuf_add_wrapped_text() Johannes Schindelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B7F0D08.6040608@lsrfire.ath.cx \
--to=rene.scharfe@lsrfire.ath.cx \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.