From: Martin Fuzzey <mfuzzey@gmail.com>
To: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
Cc: linux-serial@vger.kernel.org
Subject: Re: [PATCH 00/12] Serial : sc26xx - generalize and support SC2892
Date: Sat, 20 Feb 2010 18:55:19 +0100 [thread overview]
Message-ID: <4B802207.4080309@gmail.com> (raw)
In-Reply-To: <20100215170958.GA13994@alpha.franken.de>
Thomas Bogendoerfer wrote:
> there shouldn't be many users of this driver, it's probably just me...
> So changing names is ok for me.
>
>
> I'm fine with pushing your changes, if there are regression for
> RM system I'll take care later.
>
> Just add my Acked-By: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
> to your patches.
>
> Thomas.
>
>
Great thank you,
Can I also have an Ack for this additional patch:
Author: Martin Fuzzey <mfuzzey@gmail.com>
Date: Sat Feb 20 18:47:06 2010 +0100
Serial: sc26xx - Use ttySC0 instead of ttySC205
Use device name ttySC0 as per Documentation/devices.txt
diff --git a/drivers/serial/sc26xx.c b/drivers/serial/sc26xx.c
index 2e17bbc..9b0ede0 100644
--- a/drivers/serial/sc26xx.c
+++ b/drivers/serial/sc26xx.c
@@ -918,8 +918,6 @@ static int __devinit sc26xx_probe(struct
platform_device *dev)
if (err)
goto out_free_port;
- sc26xx_reg.tty_driver->name_base = sc26xx_reg.minor;
-
err = uart_add_one_port(&sc26xx_reg, &up->port[0]);
if (err)
goto out_unregister_driver;
If this is OK with you I'll repost the whole series with your acks and a
rename patch to sc2xxx
Cheers,
Martin
next prev parent reply other threads:[~2010-02-20 17:55 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-13 16:09 [PATCH 00/12] Serial : sc26xx - generalize and support SC2892 Martin Fuzzey
2010-02-13 16:09 ` [PATCH 01/12] Serial: Enable build of sc26xx driver for embedded platforms Martin Fuzzey
2010-02-13 16:09 ` [PATCH 02/12] Serial: sc26xx fix build errors Martin Fuzzey
2010-02-13 16:10 ` [PATCH 03/12] Serial: sc26xx - use interrupt trigger flags from resources Martin Fuzzey
2010-02-13 16:10 ` [PATCH 04/12] Serial: sc26xx - add accessor function for driver data Martin Fuzzey
2010-02-13 16:10 ` [PATCH 05/12] Serial: sc26xx - refactor register access Martin Fuzzey
2010-02-13 16:10 ` [PATCH 06/12] Serial: sc26xx simplify timeout calculation Martin Fuzzey
2010-02-13 16:10 ` [PATCH 07/12] Serial: sc26xx - simplify port initialisation Martin Fuzzey
2010-02-13 16:10 ` [PATCH 08/12] Serial: sc26xx - avoid endless loop with IRQs masked Martin Fuzzey
2010-02-13 16:10 ` [PATCH 09/12] Serial: sc26xx - add support for SC2892 chips Martin Fuzzey
2010-02-13 16:10 ` [PATCH 10/12] Serial: sc26xx - introduce a structure for platform data Martin Fuzzey
2010-02-13 16:10 ` [PATCH 11/12] Serial: sc26xx - initialise hardware if not done by bootloader Martin Fuzzey
2010-02-13 16:10 ` [PATCH 12/12] Avoid null pointer dereference Martin Fuzzey
2010-02-15 17:09 ` [PATCH 00/12] Serial : sc26xx - generalize and support SC2892 Thomas Bogendoerfer
2010-02-20 17:55 ` Martin Fuzzey [this message]
2010-02-22 9:06 ` Thomas Bogendoerfer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B802207.4080309@gmail.com \
--to=mfuzzey@gmail.com \
--cc=linux-serial@vger.kernel.org \
--cc=tsbogend@alpha.franken.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.