From mboxrd@z Thu Jan 1 00:00:00 1970 From: Noboru Iwamatsu Subject: [PATCH][RFC] gfx_passthru: warning when vgabios rom has invalid checksum Date: Mon, 22 Feb 2010 14:45:21 +0900 Message-ID: <4B8219F1.5040301@jp.fujitsu.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="------------080206040200050008010302" Return-path: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: weidong.han@intel.com, xen-devel@lists.xensource.com, Ian.Jackson@eu.citrix.com List-Id: xen-devel@lists.xenproject.org This is a multi-part message in MIME format. --------------080206040200050008010302 Content-Type: text/plain; charset=ISO-2022-JP Content-Transfer-Encoding: 7bit Hi, According to the "PCI Firmware Spec Rev 3.0", the system firmware have to write the new checksum after resizing the expansion ROM area. So, when re-using the shadowed VGABIOS, the checksum must be valid, and if it is invalid, we should consider the BIOS has a bug or memory area is corrupted. This patch just add the warning message when checksum requires recalculation. I tried this following environments. Intel DX58SO + GeForce GTS250: checksum is OK. Intel DX58SO + GeForce 9600GT: checksum is OK. Fujitsu Q35 M/B + IGD: checksum is bad. What do you think, Weidong? Is just warning enough? Or, should we stop loading the rom? Regards, Noboru. --------------080206040200050008010302 Content-Type: text/plain; name="vgabios-checksum-warn.patch" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="vgabios-checksum-warn.patch" ZGlmZiAtLWdpdCBhL2h3L3Bhc3MtdGhyb3VnaC5jIGIvaHcvcGFzcy10aHJvdWdoLmMKaW5k ZXggZWNiM2Q2Zi4uZmFkZDM1OCAxMDA2NDQKLS0tIGEvaHcvcGFzcy10aHJvdWdoLmMKKysr IGIvaHcvcGFzcy10aHJvdWdoLmMKQEAgLTQyNjIsNyArNDI2MiwxMCBAQCBzdGF0aWMgaW50 IHNldHVwX3ZnYV9wdCh2b2lkKQogICAgIGZvciAoIGMgPSAoY2hhciopYmlvczsgYyA8ICgo Y2hhciopYmlvcyArIGJpb3Nfc2l6ZSk7IGMrKyApCiAgICAgICAgIGNoZWNrc3VtICs9ICpj OwogICAgIGlmICggY2hlY2tzdW0gKQorICAgIHsKICAgICAgICAgYmlvc1tiaW9zX3NpemUg LSAxXSAtPSBjaGVja3N1bTsKKyAgICAgICAgUFRfTE9HKCJ2Z2EgYmlvcyBjaGVja3N1bSBp cyBhZGp1c3RlZCFcbiIpOworICAgIH0KIAogICAgIGNwdV9waHlzaWNhbF9tZW1vcnlfcnco MHhjMDAwMCwgYmlvcywgYmlvc19zaXplLCAxKTsKIAo= --------------080206040200050008010302 Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel --------------080206040200050008010302--