From mboxrd@z Thu Jan  1 00:00:00 1970
From: Noboru Iwamatsu <n_iwamatsu@jp.fujitsu.com>
Subject: Re: [PATCH][RFC] gfx_passthru: warning when vgabios rom
 has invalid checksum
Date: Mon, 22 Feb 2010 17:00:11 +0900
Message-ID: <4B82398B.6020109@jp.fujitsu.com>
References: <4B8219F1.5040301@jp.fujitsu.com> <4B823088.8090706@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xensource.com>
In-Reply-To: <4B823088.8090706@intel.com>
List-Unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: weidong.han@intel.com
Cc: xen-devel@lists.xensource.com, Ian.Jackson@eu.citrix.com
List-Id: xen-devel@lists.xenproject.org

Hi,

 >> Intel DX58SO + GeForce GTS250:	checksum is OK.
 >> Intel DX58SO + GeForce 9600GT:	checksum is OK.
 >> Fujitsu Q35 M/B + IGD:		checksum is bad.
 >>
 > What does "checksum is bad" mean here?

It means shadowed VGABIOS has invalid checksum
and requires recalculating.

 >> What do you think, Weidong?
 >> Is just warning enough? Or, should we stop loading the rom?
 >>
 >>
 > Does it still work or not when checksum is bad? If it works, we should
 > not stop loading the rom.

When the checksum is bad,
if it is not recalculated, guest has some trouble about handling the
VGA (unable to show BIOS screen, unable to load the gfx driver
properly, ...).
If it is recalculated, it seems to work fine.

Regards,
Noboru.

> Noboru Iwamatsu wrote:
>> Hi,
>>
>> According to the "PCI Firmware Spec Rev 3.0",
>> the system firmware have to write the new checksum after resizing
>> the expansion ROM area.
>>
>> So, when re-using the shadowed VGABIOS, the checksum must
>> be valid, and if it is invalid, we should consider the BIOS has
>> a bug or memory area is corrupted.
>>
>> This patch just add the warning message when checksum requires
>> recalculation.
>>
>> I tried this following environments.
>>
>> Intel DX58SO + GeForce GTS250:	checksum is OK.
>> Intel DX58SO + GeForce 9600GT:	checksum is OK.
>> Fujitsu Q35 M/B + IGD:		checksum is bad.
>>
> What does "checksum is bad" mean here?
>> What do you think, Weidong?
>> Is just warning enough? Or, should we stop loading the rom?
>>
>>
> Does it still work or not when checksum is bad? If it works, we should
> not stop loading the rom.
>
> Regards,
> Weidong
>> Regards,
>> Noboru.
>>
>