From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jan Kiszka Subject: Re: [PATCH][uq/master] KVM: x86: Fix eflags corruption in kvm mode Date: Mon, 22 Feb 2010 09:13:14 +0100 Message-ID: <4B823C9A.2010205@siemens.com> References: <4B7EC890.8000309@siemens.com> <4B80F983.7040706@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit Cc: Anthony Liguori , Marcelo Tosatti , qemu-devel , kvm To: Avi Kivity Return-path: In-Reply-To: <4B80F983.7040706@redhat.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: qemu-devel-bounces+gceq-qemu-devel=gmane.org@nongnu.org Errors-To: qemu-devel-bounces+gceq-qemu-devel=gmane.org@nongnu.org List-Id: kvm.vger.kernel.org Avi Kivity wrote: > On 02/19/2010 07:21 PM, Jan Kiszka wrote: >> This should explain a lot of the weird breakages of upstream KVM we've >> seen recently (actually we should have seen it much earlier): >> >> Stop translating eflags into TCG format when in kvm mode as we never >> translate it back and rather sync this broken state into the kernel. >> >> > > Applied to uq/master and uq/stable-0.12, thanks (though realistically > 0.12 kvm users should stick with qemu-kvm). > Actually, I would prefer if more "light" kvm users (no demanding performance requirements, no dependency on qemu-kvm-only features) consider upstream instead of qemu-kvm so that it gains way more testing than just by us when pushing some more bits. So we should keep on informing people about limitations and known issues. We need them on both sides. Jan -- Siemens AG, Corporate Technology, CT T DE IT 1 Corporate Competence Center Embedded Linux From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NjTQ9-0005wq-VS for qemu-devel@nongnu.org; Mon, 22 Feb 2010 03:13:38 -0500 Received: from [199.232.76.173] (port=49919 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NjTQ4-0005vd-Gn for qemu-devel@nongnu.org; Mon, 22 Feb 2010 03:13:32 -0500 Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60) (envelope-from ) id 1NjTQ1-0004lw-W7 for qemu-devel@nongnu.org; Mon, 22 Feb 2010 03:13:32 -0500 Received: from goliath.siemens.de ([192.35.17.28]:20342) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1NjTQ0-0004ku-Ns for qemu-devel@nongnu.org; Mon, 22 Feb 2010 03:13:29 -0500 Message-ID: <4B823C9A.2010205@siemens.com> Date: Mon, 22 Feb 2010 09:13:14 +0100 From: Jan Kiszka MIME-Version: 1.0 References: <4B7EC890.8000309@siemens.com> <4B80F983.7040706@redhat.com> In-Reply-To: <4B80F983.7040706@redhat.com> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] Re: [PATCH][uq/master] KVM: x86: Fix eflags corruption in kvm mode List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Avi Kivity Cc: Anthony Liguori , Marcelo Tosatti , qemu-devel , kvm Avi Kivity wrote: > On 02/19/2010 07:21 PM, Jan Kiszka wrote: >> This should explain a lot of the weird breakages of upstream KVM we've >> seen recently (actually we should have seen it much earlier): >> >> Stop translating eflags into TCG format when in kvm mode as we never >> translate it back and rather sync this broken state into the kernel. >> >> > > Applied to uq/master and uq/stable-0.12, thanks (though realistically > 0.12 kvm users should stick with qemu-kvm). > Actually, I would prefer if more "light" kvm users (no demanding performance requirements, no dependency on qemu-kvm-only features) consider upstream instead of qemu-kvm so that it gains way more testing than just by us when pushing some more bits. So we should keep on informing people about limitations and known issues. We need them on both sides. Jan -- Siemens AG, Corporate Technology, CT T DE IT 1 Corporate Competence Center Embedded Linux