From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH][uq/master] KVM: x86: Fix eflags corruption in kvm mode Date: Mon, 22 Feb 2010 10:24:04 +0200 Message-ID: <4B823F24.7060406@redhat.com> References: <4B7EC890.8000309@siemens.com> <4B80F983.7040706@redhat.com> <4B823C9A.2010205@siemens.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit Cc: Marcelo Tosatti , qemu-devel , kvm , Anthony Liguori To: Jan Kiszka Return-path: Received: from mx1.redhat.com ([209.132.183.28]:42832 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752043Ab0BVIYJ (ORCPT ); Mon, 22 Feb 2010 03:24:09 -0500 In-Reply-To: <4B823C9A.2010205@siemens.com> Sender: kvm-owner@vger.kernel.org List-ID: On 02/22/2010 10:13 AM, Jan Kiszka wrote: > Avi Kivity wrote: > >> On 02/19/2010 07:21 PM, Jan Kiszka wrote: >> >>> This should explain a lot of the weird breakages of upstream KVM we've >>> seen recently (actually we should have seen it much earlier): >>> >>> Stop translating eflags into TCG format when in kvm mode as we never >>> translate it back and rather sync this broken state into the kernel. >>> >>> >>> >> Applied to uq/master and uq/stable-0.12, thanks (though realistically >> 0.12 kvm users should stick with qemu-kvm). >> >> > Actually, I would prefer if more "light" kvm users (no demanding > performance requirements, no dependency on qemu-kvm-only features) > consider upstream instead of qemu-kvm so that it gains way more testing > than just by us when pushing some more bits. So we should keep on > informing people about limitations and known issues. We need them on > both sides. > > Agreed. -- error compiling committee.c: too many arguments to function From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NjTaK-0007ta-Fo for qemu-devel@nongnu.org; Mon, 22 Feb 2010 03:24:08 -0500 Received: from [199.232.76.173] (port=55957 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NjTaK-0007tQ-0m for qemu-devel@nongnu.org; Mon, 22 Feb 2010 03:24:08 -0500 Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60) (envelope-from ) id 1NjTaJ-0005dR-3E for qemu-devel@nongnu.org; Mon, 22 Feb 2010 03:24:07 -0500 Received: from mx1.redhat.com ([209.132.183.28]:46263) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1NjTaI-0005dL-OA for qemu-devel@nongnu.org; Mon, 22 Feb 2010 03:24:06 -0500 Message-ID: <4B823F24.7060406@redhat.com> Date: Mon, 22 Feb 2010 10:24:04 +0200 From: Avi Kivity MIME-Version: 1.0 References: <4B7EC890.8000309@siemens.com> <4B80F983.7040706@redhat.com> <4B823C9A.2010205@siemens.com> In-Reply-To: <4B823C9A.2010205@siemens.com> Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] Re: [PATCH][uq/master] KVM: x86: Fix eflags corruption in kvm mode List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jan Kiszka Cc: Anthony Liguori , Marcelo Tosatti , qemu-devel , kvm On 02/22/2010 10:13 AM, Jan Kiszka wrote: > Avi Kivity wrote: > >> On 02/19/2010 07:21 PM, Jan Kiszka wrote: >> >>> This should explain a lot of the weird breakages of upstream KVM we've >>> seen recently (actually we should have seen it much earlier): >>> >>> Stop translating eflags into TCG format when in kvm mode as we never >>> translate it back and rather sync this broken state into the kernel. >>> >>> >>> >> Applied to uq/master and uq/stable-0.12, thanks (though realistically >> 0.12 kvm users should stick with qemu-kvm). >> >> > Actually, I would prefer if more "light" kvm users (no demanding > performance requirements, no dependency on qemu-kvm-only features) > consider upstream instead of qemu-kvm so that it gains way more testing > than just by us when pushing some more bits. So we should keep on > informing people about limitations and known issues. We need them on > both sides. > > Agreed. -- error compiling committee.c: too many arguments to function