From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1Nja7U-00038B-Hs
	for qemu-devel@nongnu.org; Mon, 22 Feb 2010 10:22:48 -0500
Received: from [199.232.76.173] (port=38449 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Nja7U-00037t-2K
	for qemu-devel@nongnu.org; Mon, 22 Feb 2010 10:22:48 -0500
Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim
	4.60) (envelope-from <weil@mail.berlios.de>) id 1Nja7S-0003Pj-Pi
	for qemu-devel@nongnu.org; Mon, 22 Feb 2010 10:22:47 -0500
Received: from moutng.kundenserver.de ([212.227.17.9]:57545)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <weil@mail.berlios.de>) id 1Nja7S-0003PR-2o
	for qemu-devel@nongnu.org; Mon, 22 Feb 2010 10:22:46 -0500
Message-ID: <4B82A142.9060608@mail.berlios.de>
Date: Mon, 22 Feb 2010 16:22:42 +0100
From: Stefan Weil <weil@mail.berlios.de>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH v2] tcg: fix assertion with --enable-debug
References: <ee2e06e91002200208t4bfb6c10rbb797e09cfd712e4@mail.gmail.com>	<f43fc5581002200232h72ac0f7erc0ee7cd4f92a4250@mail.gmail.com>	<4B8295EB.5080003@suse.de>
	<ee2e06e91002220642j295a4867p6af4efa4499c5a71@mail.gmail.com>
In-Reply-To: <ee2e06e91002220642j295a4867p6af4efa4499c5a71@mail.gmail.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 8bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Jay Foad <jay.foad@gmail.com>
Cc: Blue Swirl <blauwirbel@gmail.com>, Alexander Graf <agraf@suse.de>, qemu-devel@nongnu.org

Jay Foad schrieb:
>> This patch breaks building on ppc32. Reverting it makes it compile again:
>>     
>
>   
>> /suse/agraf/git/qemu/tcg/ppc/tcg-target.c:1696: error:
>> ‘INDEX_op_qemu_ld32s’ undeclared here (not in a function)
>>     
>
> Does it build if you remove line 1696? If so, I'd suggest doing that.
>
> Thanks,
> Jay.

Removing the line helps only in that special case.
#if TCG_TARGET_REG_BITS == 64 ... #endif
is better. I can provide a patch.

Regards,
Stefan