From: Stefan Weil <weil@mail.berlios.de>
To: Jay Foad <jay.foad@gmail.com>
Cc: qemu-devel@nongnu.org, Alexander Graf <agraf@suse.de>
Subject: Re: [Qemu-devel] [PATCH] tcg: fix build on 32-bit hppa, ppc and sparc hosts
Date: Mon, 22 Feb 2010 17:58:44 +0100 [thread overview]
Message-ID: <4B82B7C4.3000701@mail.berlios.de> (raw)
In-Reply-To: <ee2e06e91002220837v3268c0c6ieb509ca862f143e5@mail.gmail.com>
Jay Foad schrieb:
>>> --- a/tcg/ppc/tcg-target.c
>>> +++ b/tcg/ppc/tcg-target.c
>>> @@ -1693,7 +1693,6 @@ static const TCGTargetOpDef ppc_op_defs[] = {
>>> { INDEX_op_qemu_ld16u, { "r", "L" } },
>>> { INDEX_op_qemu_ld16s, { "r", "L" } },
>>> { INDEX_op_qemu_ld32u, { "r", "L" } },
>>> - { INDEX_op_qemu_ld32s, { "r", "L" } },
>>>
>>>
>> No. As I wrote in the original thread,
>> conditional compilation is needed here
>> (or you will get new compile errors).
>>
>
> In tcg/ppc/, TCG_TARGET_REG_BITS is always 32, isn't it?
>
> Thanks,
> Jay.
>
Yes, you are right. Please excuse my wrong feedback.
Stefan
next prev parent reply other threads:[~2010-02-22 16:58 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-22 15:53 [Qemu-devel] [PATCH] tcg: fix build on 32-bit hppa, ppc and sparc hosts Jay Foad
2010-02-22 16:35 ` Stefan Weil
2010-02-22 16:37 ` Jay Foad
2010-02-22 16:58 ` Stefan Weil [this message]
2010-03-03 22:06 ` Stuart Brady
2010-02-22 16:42 ` malc
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B82B7C4.3000701@mail.berlios.de \
--to=weil@mail.berlios.de \
--cc=agraf@suse.de \
--cc=jay.foad@gmail.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.