All of lore.kernel.org
 help / color / mirror / Atom feed
From: Clemens Ladisch <clemens@ladisch.de>
To: Daniel Mack <daniel@caiaq.de>
Cc: "岩井 隆" <tiwai@suse.de>, alsa-devel@alsa-project.org
Subject: Re: usbaudio: Support for USB audio v2.0 devices
Date: Mon, 22 Feb 2010 18:40:39 +0100	[thread overview]
Message-ID: <4B82C197.1050004@ladisch.de> (raw)
In-Reply-To: <1266856137-26252-1-git-send-email-daniel@caiaq.de>

Daniel Mack wrote:
> I've been working on support for USB devices compliant to audio class
> v2.0 and would like to share what I got.

Great!

Just out of curiousity: what device are you testing this with?

> My first step was to clean up most of the existing descriptor parsers
> by moving away from anonymous byte array access to real structs so we
> can see which fields we're actually dereferencing.

Please use the structures in <linux/usb/audio.h>.

> * Supported sample formats are now reported as 32bit bitmap rather than
>   as a fixed value. For now, this is worked around by choosing just one
>   of them.

I'll write a patch to change struct audioformat to use a bitmask.

> Let me know what you think.

Haven't tested yet, but the patches look fine.


Regards,
Clemens

  parent reply	other threads:[~2010-02-22 17:40 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-02-22 16:28 usbaudio: Support for USB audio v2.0 devices Daniel Mack
2010-02-22 16:28 ` [PATCH 1/4] ALSA: usbaudio: parse USB descriptors with structs Daniel Mack
2010-02-22 16:28 ` [PATCH 2/4] ALSA: usbaudio: introduce new types for audio class v2 Daniel Mack
2010-02-22 16:28 ` [PATCH 3/4] ALSA: usbaudio: implement basic set of class v2.0 parser Daniel Mack
2010-02-22 16:28 ` [PATCH 4/4] ALSA: usbmixer: bail out early when parsing audio class v2 descriptors Daniel Mack
2010-02-22 17:40 ` Clemens Ladisch [this message]
2010-02-22 17:50   ` usbaudio: Support for USB audio v2.0 devices Daniel Mack
2010-03-02  9:13 ` adelias
2010-03-02 18:35   ` Daniel Mack
2010-04-27 13:23     ` adelias
2010-04-27 13:31       ` The Source
2010-04-27 14:07         ` Daniel Mack
2010-04-27 15:29           ` The Source
2010-04-27 15:43             ` Daniel Mack
2010-04-27 17:27               ` The Source
2010-04-27 17:33                 ` Daniel Mack
2010-05-02 16:56                   ` The Source
2010-05-03 20:55                     ` Daniel Mack
2010-05-07 13:19                       ` The Source
2010-05-07 13:22                         ` Daniel Mack
2010-05-07 20:12                         ` Daniel Mack
2010-05-07 21:32                           ` The Source
2010-05-08  1:38                             ` Daniel Mack
2010-05-08  7:26                           ` The Source
2010-05-08  9:19                             ` Daniel Mack
2010-05-08  9:24                             ` [PATCH] ALSA: sound/usb: fix UAC1 regression Daniel Mack
2010-05-08  9:45                               ` Takashi Iwai
2010-04-27 14:06       ` usbaudio: Support for USB audio v2.0 devices Daniel Mack
2010-05-03 12:49         ` adelias
2010-05-04 10:48           ` Daniel Mack
2010-05-18  7:07             ` adelias
2010-05-18  7:40               ` Daniel Mack
2010-05-18  8:32                 ` adelias
2010-05-27 18:21               ` Daniel Mack
  -- strict thread matches above, loose matches on Subject: below --
2010-02-22 22:49 Daniel Mack

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4B82C197.1050004@ladisch.de \
    --to=clemens@ladisch.de \
    --cc=alsa-devel@alsa-project.org \
    --cc=daniel@caiaq.de \
    --cc=tiwai@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.