From mboxrd@z Thu Jan 1 00:00:00 1970 From: Oren Laadan Subject: Re: [PATCH][user-cr]: ckptinfo: Have -v imply -p option Date: Mon, 22 Feb 2010 17:52:58 -0500 Message-ID: <4B830ACA.4090407@cs.columbia.edu> References: <20100219193643.GA332@us.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20100219193643.GA332-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org To: Sukadev Bhattiprolu Cc: Containers List-Id: containers.vger.kernel.org Sukadev Bhattiprolu wrote: > Do we even need the -p option ? It is not used without the -v at present. > Can we drop the -p and have -v print filepos always ? Ok. I'll do that. Oren. > > --- > From: Sukadev Bhattiprolu > Date: Fri, 19 Feb 2010 11:19:08 -0800 > Subject: [PATCH 1/1] ckptinfo: Have -v imply -p > > When the -v is chosen, user wants verbose debug information. The > filepos would be useful to correlate with the kernel debug messages > and does not clutter the output. > > Signed-off-by: Sukadev Bhattiprolu > --- > ckptinfo.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/ckptinfo.c b/ckptinfo.c > index 6859742..be91b80 100644 > --- a/ckptinfo.c > +++ b/ckptinfo.c > @@ -135,7 +135,7 @@ int main(int argc, char *argv[]) > > if (args.verbose) > __verbose = 1; > - if (args.position) > + if (args.position || args.verbose) > __position = 1; > > argc -= optind;