From: Sakari Ailus <sakari.ailus@maxwell.research.nokia.com>
To: Hans Verkuil <hverkuil@xs4all.nl>
Cc: linux-media@vger.kernel.org,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
david.cohen@nokia.com
Subject: Re: [PATCH 6/6] V4L: Events: Add documentation
Date: Tue, 23 Feb 2010 09:55:44 +0200 [thread overview]
Message-ID: <4B838A00.5060103@maxwell.research.nokia.com> (raw)
In-Reply-To: <201002230819.24988.hverkuil@xs4all.nl>
Hans Verkuil wrote:
> On Tuesday 23 February 2010 00:27:30 Sakari Ailus wrote:
>> Hans Verkuil wrote:
>>> On Monday 22 February 2010 23:47:49 Sakari Ailus wrote:
>>>> Will be "There are standard and private events. New standard events must
>>>> use the smallest available event type. The drivers must allocate their
>>>> events starting from base (V4L2_EVENT_PRIVATE_START + n * 1024) + 1." in
>>>> the next one.
>>>
>>> Ah, OK. But why '+ 1'? I don't really see a reason for that to be honest.
>>> Am I missing something?
>>
>> Many V4L2 control classes do that. No other reason really. :-) Can be
>> removed on my behalf.
>
> Then this can be removed. There are reasons for doing that with controls, but
> those reasons do not apply to events (mostly to do with the CTRL_NEXT flag).
Good point.
Would we want to enumerate events in future perhaps? If so, it might
still be a good idea to keep this for now. What do you think?
--
Sakari Ailus
sakari.ailus@maxwell.research.nokia.com
next prev parent reply other threads:[~2010-02-23 7:56 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-22 15:51 [PATCH v6 0/6] V4L2 file handles and event interface Sakari Ailus
2010-02-22 15:51 ` [PATCH 1/6] V4L: File handles Sakari Ailus
2010-02-22 15:51 ` [PATCH 2/6] V4L: File handles: Add documentation Sakari Ailus
2010-02-22 15:51 ` [PATCH 3/6] V4L: Events: Add new ioctls for events Sakari Ailus
2010-02-22 15:51 ` [PATCH 4/6] V4L: Events: Add backend Sakari Ailus
2010-02-22 15:51 ` [PATCH 5/6] V4L: Events: Support event handling in do_ioctl Sakari Ailus
2010-02-22 15:51 ` [PATCH 6/6] V4L: Events: Add documentation Sakari Ailus
2010-02-22 19:57 ` Hans Verkuil
2010-02-22 22:47 ` Sakari Ailus
2010-02-22 23:20 ` Hans Verkuil
2010-02-22 23:27 ` Sakari Ailus
2010-02-23 7:19 ` Hans Verkuil
2010-02-23 7:55 ` Sakari Ailus [this message]
2010-02-22 20:02 ` [PATCH 5/6] V4L: Events: Support event handling in do_ioctl Hans Verkuil
2010-02-22 19:58 ` [PATCH 4/6] V4L: Events: Add backend Hans Verkuil
2010-02-22 19:58 ` [PATCH 3/6] V4L: Events: Add new ioctls for events Hans Verkuil
2010-02-22 19:58 ` [PATCH 2/6] V4L: File handles: Add documentation Hans Verkuil
2010-02-22 16:00 ` [PATCH 1/6] V4L: File handles Sakari Ailus
2010-02-22 19:57 ` Hans Verkuil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B838A00.5060103@maxwell.research.nokia.com \
--to=sakari.ailus@maxwell.research.nokia.com \
--cc=david.cohen@nokia.com \
--cc=hverkuil@xs4all.nl \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-media@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.