From: Milan Broz <mbroz@redhat.com>
To: lvm-devel@redhat.com
Subject: [PATCH] Add mirror log to dependency tree using its UUID.
Date: Tue, 23 Feb 2010 12:15:17 +0100 [thread overview]
Message-ID: <4B83B8C5.7090207@redhat.com> (raw)
In-Reply-To: <8763624zfz.fsf@twilight.int.mornfall.net.>
On 02/12/2010 09:42 AM, Petr Rockai wrote:
> If I was a little more careful to check the patch, this could have been
> easy... You have moved the _mlog from _add_lv_to_dtree to
> _create_partial_dtree -- but this is not correct! The following patch
> works:
:-)
> @@ -823,7 +823,8 @@ static int _add_lv_to_dtree(struct dev_m
> if (!_add_dev_to_dtree(dm, dtree, lv, "cow"))
> return_0;
>
> - if (!_add_dev_to_dtree(dm, dtree, lv, "_mlog"))
> + if ((lv->status & MIRRORED) && first_seg(lv)->log_lv &&
> + !_add_dev_to_dtree(dm, dtree, first_seg(lv)->log_lv, NULL))
> return_0;
yes, this seem to be correct, ack
Milan
prev parent reply other threads:[~2010-02-23 11:15 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-01 10:51 [PATCH] Add mirror log to dependency tree using its UUID Milan Broz
2010-02-12 8:42 ` Petr Rockai
2010-02-23 11:15 ` Milan Broz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B83B8C5.7090207@redhat.com \
--to=mbroz@redhat.com \
--cc=lvm-devel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.