Re: [PATCH] DSPBRIDGE: Get rid of memset() from MEM_Calloc()

[Omar Ramirez Luna <omar.ramirez@ti.com>]

On 2/16/2010 9:40 AM, Ameya Palande wrote:
> Signed-off-by: Ameya Palande<ameya.palande@nokia.com>
> ---
>   drivers/dsp/bridge/services/mem.c |   11 ++++-------
>   1 files changed, 4 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/dsp/bridge/services/mem.c b/drivers/dsp/bridge/services/mem.c
> index 614396e..2501eee 100644
> --- a/drivers/dsp/bridge/services/mem.c
> +++ b/drivers/dsp/bridge/services/mem.c
> @@ -227,16 +227,13 @@ void *MEM_Calloc(u32 cBytes, enum MEM_POOLATTRS type)
>   		case MEM_NONPAGED:
>   		/* If non-paged memory required, see note at top of file. */
>   		case MEM_PAGED:
> -			pMem = kmalloc(cBytes,
> +			pMem = kzalloc(cBytes,
>   				(in_atomic()) ? GFP_ATOMIC : GFP_KERNEL);
> -			if (pMem)
> -				memset(pMem, 0, cBytes);
> -
>   			break;
>   		case MEM_LARGEVIRTMEM:
> -			pMem = vmalloc(cBytes);
> -			if (pMem)
> -				memset(pMem, 0, cBytes);
> +			pMem = __vmalloc(cBytes,
> +				GFP_KERNEL | __GFP_HIGHMEM | __GFP_ZERO,
> +				PAGE_KERNEL);
>   			break;
>   		default:
>   			GT_1trace(MEM_debugMask, GT_6CLASS,

Acked-by: Omar Ramirez Luna <omar.ramirez@ti.com>

Pushed to dspbridge

- omar