From: Gabriel Filion <lelutin@gmail.com>
To: Paolo Bonzini <bonzini@gnu.org>
Cc: Ilari Liusvaara <ilari.liusvaara@elisanet.fi>, git@vger.kernel.org
Subject: Re: [PATCH] Allow '+', '-' and '.' in remote helper names
Date: Tue, 23 Feb 2010 12:12:19 -0500 [thread overview]
Message-ID: <4B840C73.8020204@gmail.com> (raw)
In-Reply-To: <4B83DCB1.5050905@gnu.org>
Paolo Bonzini wrote:
> On 02/23/2010 01:33 PM, Ilari Liusvaara wrote:
>> According to relevant RFCs, in addition to alphanumerics, the following
>> characters are valid in URL scheme parts: '+', '-' and '.', but
>> currently only alphanumerics are allowed in remote helper names.
>>
>> Allow those three characters in remote helper names (both 'foo://' and
>> 'foo::' syntax).
>
> I think '+' could be special-cased in that, for example, "svn+ssh://"
> should still invoke an hypothetic git-remote-svn helper. There is no
> use yet for this feature, but I'm sure that foreign VCS helpers would
> use it.
>
Special-casing the + could be useful to simplify support for
"svn::ssh://"-style addresses as both could receive the same URL
("ssh://..").
It would also mean less clutter in the script directory. Instead of
having two scripts, one to catch "helper://.." remote URLs and another
to catch "helper+ssh://.." URLs, the same script would differentiate
between used protocols.
--
Gabriel Filion
prev parent reply other threads:[~2010-02-23 17:12 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-23 12:33 [PATCH] Allow '+', '-' and '.' in remote helper names Ilari Liusvaara
2010-02-23 13:03 ` Johannes Schindelin
2010-02-23 13:07 ` Sverre Rabbelier
2010-02-23 13:51 ` Johannes Schindelin
2010-02-23 13:19 ` Johannes Sixt
2010-02-23 13:32 ` Erik Faye-Lund
2010-02-23 14:42 ` Johannes Schindelin
2010-02-23 13:48 ` Paolo Bonzini
2010-02-23 17:12 ` Gabriel Filion [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B840C73.8020204@gmail.com \
--to=lelutin@gmail.com \
--cc=bonzini@gnu.org \
--cc=git@vger.kernel.org \
--cc=ilari.liusvaara@elisanet.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.