All of lore.kernel.org
 help / color / mirror / Atom feed
From: Chris Kilgour <techie@whiterocker.com>
To: Anthony Liguori <anthony@codemonkey.ws>
Cc: qemu-devel@nongnu.org
Subject: [Qemu-devel] [PATCH] pcnet APROMWE bit location (retry)
Date: Tue, 23 Feb 2010 22:32:14 -0800	[thread overview]
Message-ID: <4B84C7EE.4050303@whiterocker.com> (raw)
In-Reply-To: <4B7F0390.1030206@codemonkey.ws>


According to AMD document 21485D pp.141, APROMWE is bit 8 of BCR2.

Signed-off-by: Christopher Kilgour <techie@whiterocker.com>

---
diff --git a/hw/pcnet.c b/hw/pcnet.c
index 44b5b31..f889898 100644
--- a/hw/pcnet.c
+++ b/hw/pcnet.c
@@ -1601,7 +1601,7 @@ static void pcnet_aprom_writeb(void *opaque, uint32_t addr, uint32_t val)
     printf("pcnet_aprom_writeb addr=0x%08x val=0x%02x\n", addr, val);
 #endif
     /* Check APROMWE bit to enable write access */
-    if (pcnet_bcr_readw(s,2) & 0x80)
+    if (pcnet_bcr_readw(s,2) & 0x100)
         s->prom[addr & 15] = val;
 }

  reply	other threads:[~2010-02-24  6:32 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-02-15  1:53 [Qemu-devel] [PATCH] pcnet APROMWE bit location Chris Kilgour
2010-02-19 21:33 ` Anthony Liguori
2010-02-24  6:32   ` Chris Kilgour [this message]
2010-03-09 14:24     ` [Qemu-devel] [PATCH] pcnet APROMWE bit location (retry) Anthony Liguori

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4B84C7EE.4050303@whiterocker.com \
    --to=techie@whiterocker.com \
    --cc=anthony@codemonkey.ws \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.