All of lore.kernel.org
 help / color / mirror / Atom feed
From: Johannes Sixt <j.sixt@viscovery.net>
To: Matt Kraai <kraai@ftbfs.org>
Cc: gitster@pobox.com, git@vger.kernel.org
Subject: Re: [PATCH] commit: quote the user name in the example
Date: Wed, 24 Feb 2010 08:49:23 +0100	[thread overview]
Message-ID: <4B84DA03.1040809@viscovery.net> (raw)
In-Reply-To: <1266980049-5835-1-git-send-email-kraai@ftbfs.org>

Matt Kraai schrieb:
> If the user runs
> 
>  git config --global user.name Your Name
> 
> as suggested, user.name will be set to "Your".  With this patch, the
> suggested command will be
> 
>  git config --global user.name 'Your Name'
> 
> which will set user.name to "Your Name" and hopefully help users avoid
> the former mistake.

Actually, I would prefer that the suggested command is

  git config --global user.name "Your Name"

i.e., with double-quotes, because then the suggestion is also correct for
Windows users who run git from CMD: in this environment, single-quotes do
not quote, but double-quotes do.

-- Hannes

  parent reply	other threads:[~2010-02-24  7:49 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-02-24  2:54 [PATCH] commit: quote the user name in the example Matt Kraai
2010-02-24  3:00 ` Junio C Hamano
2010-02-24  7:49 ` Johannes Sixt [this message]
2010-02-24 14:18   ` Matt Kraai
2010-02-24 14:19   ` Matt Kraai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4B84DA03.1040809@viscovery.net \
    --to=j.sixt@viscovery.net \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=kraai@ftbfs.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.