All of lore.kernel.org
 help / color / mirror / Atom feed
From: Shan Wei <shanwei@cn.fujitsu.com>
To: Alexey Dobriyan <adobriyan@gmail.com>
Cc: netdev@vger.kernel.org
Subject: Re: [RFC PATCH net-next 1/5]IPv6:netfilter: defrag:Introduce net namespace
Date: Wed, 24 Feb 2010 16:26:10 +0800	[thread overview]
Message-ID: <4B84E2A2.6020006@cn.fujitsu.com> (raw)
In-Reply-To: <b6fcc0a1002232348y6ff84ca8wf3bdf21de45fffbd@mail.gmail.com>

Alexey Dobriyan wrote, at 02/24/2010 03:48 PM:
>> -		.procname	= "nf_conntrack_frag6_timeout",
>> -		.data		= &nf_init_frags.timeout,
>> -		.maxlen		= sizeof(unsigned int),
>> -		.mode		= 0644,
>> -		.proc_handler	= proc_dointvec_jiffies,
> 
> Why are you removing sysctls?

Because, after introduced net namespace, we can use net->ipv6.frags to 
manage IPv6 conntrack fragment queue instead of nf_init_frags. 
And sysctls of ip6frag_low_thresh, ip6frag_time and ip6frag_high_thresh 
also can control IPv6 conntrack fragment queue.

So, private member of nf_init_frags becomes redundant, and remove these sysctls. 

-- 
Best Regards
-----
Shan Wei

  reply	other threads:[~2010-02-24  8:26 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-02-24  7:48 [RFC PATCH net-next 1/5]IPv6:netfilter: defrag:Introduce net namespace Alexey Dobriyan
2010-02-24  8:26 ` Shan Wei [this message]
2010-02-24 14:05   ` Patrick McHardy
2010-02-25 11:36     ` Shan Wei
2010-02-25 17:34       ` Patrick McHardy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4B84E2A2.6020006@cn.fujitsu.com \
    --to=shanwei@cn.fujitsu.com \
    --cc=adobriyan@gmail.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.