From: Richard Henderson <rth@twiddle.net>
To: Aurelien Jarno <aurelien@aurel32.net>
Cc: laurent.desnogues@gmail.com, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 0/6] target-alpha: fpu qualifiers, round 2
Date: Wed, 24 Feb 2010 12:24:55 +0100 [thread overview]
Message-ID: <4B850C87.8060101@twiddle.net> (raw)
In-Reply-To: <20100223225825.GS10348@hall.aurel32.net>
On 02/23/2010 02:58 PM, Aurelien Jarno wrote:
>> I have totally rewritten the patch to be more along the line
>> that Laurent was suggesting, in that the rounding mode and other
>> qualifiers are totally parsed within the translator. I no longer
>> pass the FN11 field to the helper functions.
>
> What's the benefit of doing that? I don't say it's wrong, I just want
> to understand. Otherwise the patch looks good, so it can probably be
> applied without any change.
I seem to recall Laurent opining that doing the interpretation
of the opcode in two different places was less than clean, and
in the end I agree with him.
FWIW, this configuration would also be compatible with a
future TCG enhancement to generate fp code, whereas the first
config would not.
r~
next prev parent reply other threads:[~2010-02-24 11:25 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20091228201020.GD5695@hall.aurel32.net>
2009-12-18 22:09 ` [Qemu-devel] [patch] target-alpha: squashed fpu qualifiers patch Richard Henderson
2010-01-04 22:46 ` [Qemu-devel] [PATCH 0/6] target-alpha: fpu qualifiers, round 2 Richard Henderson
2009-12-31 19:54 ` [Qemu-devel] [PATCH 1/6] target-alpha: Fix gdb access to fpcr and unique Richard Henderson
2009-12-31 20:41 ` [Qemu-devel] [PATCH 2/6] target-alpha: Split up FPCR value into separate fields Richard Henderson
2010-01-04 19:19 ` [Qemu-devel] [PATCH 3/6] target-alpha: Reduce internal processor registers for user-mode Richard Henderson
2010-01-06 9:55 ` Tristan Gingold
2010-01-06 16:29 ` Richard Henderson
2010-01-06 17:04 ` Andreas Färber
2010-01-07 11:54 ` Tristan Gingold
2010-01-07 20:13 ` Andreas Färber
2010-01-04 19:24 ` [Qemu-devel] [PATCH 4/6] target-alpha: Clean up arithmetic traps Richard Henderson
2010-01-04 19:25 ` [Qemu-devel] [PATCH 5/6] target-alpha: Mark helper_excp as NORETURN Richard Henderson
2010-01-04 22:27 ` [Qemu-devel] [PATCH 6/6] target-alpha: Implement IEEE FP qualifiers Richard Henderson
2010-01-26 16:35 ` [Qemu-devel] [PATCH 0/6] target-alpha: fpu qualifiers, round 2 Richard Henderson
2010-02-09 18:47 ` Richard Henderson
2010-02-23 22:58 ` Aurelien Jarno
2010-02-24 11:24 ` Richard Henderson [this message]
2010-02-28 16:49 ` Aurelien Jarno
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B850C87.8060101@twiddle.net \
--to=rth@twiddle.net \
--cc=aurelien@aurel32.net \
--cc=laurent.desnogues@gmail.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.