Re: [PATCH] tsc2007 : set irq edge

[Matthieu CASTET <matthieu.castet-ITF29qwbsa/QT0dZR+AlfA@public.gmane.org>]

[-- Attachment #1: Type: text/plain, Size: 546 bytes --]

Matthieu CASTET a écrit :
> Hi,
> 
> We need to pass a trigger flag for the interruption to work with some
> gpio controller.
> 
> This patch make it work on a arm omap chip.
> 
> Signed-off-by: Matthieu CASTET <matthieu.castet-ITF29qwbsa/QT0dZR+AlfA@public.gmane.org>
> 

in fact we should trigger on low level.
The problem with falling edge is that we trigger irq when sending
command to chip even if there are disable : there are resend on irq_enable!


Signed-off-by: Matthieu CASTET <matthieu.castet-ITF29qwbsa/QT0dZR+AlfA@public.gmane.org>

[-- Attachment #2: tsc2007_irq.diff --]
[-- Type: text/x-diff, Size: 556 bytes --]

diff --git a/drivers/input/touchscreen/tsc2007.c b/drivers/input/touchscreen/tsc2007.c
index 7ef0d14..a16b9e5 100644
--- a/drivers/input/touchscreen/tsc2007.c
+++ b/drivers/input/touchscreen/tsc2007.c
@@ -312,7 +312,7 @@ static int __devinit tsc2007_probe(struct i2c_client *client,
 	if (pdata->init_platform_hw)
 		pdata->init_platform_hw();
 
-	err = request_irq(ts->irq, tsc2007_irq, 0,
+	err = request_irq(ts->irq, tsc2007_irq, IRQF_TRIGGER_LOW,
 			client->dev.driver->name, ts);
 	if (err < 0) {
 		dev_err(&client->dev, "irq %d busy?\n", ts->irq);