From: Taku Izumi <izumi.taku@jp.fujitsu.com>
To: Laurent Chavey <chavey@google.com>
Cc: jeffrey.t.kirsher@intel.com, "Brandeburg,
Jesse" <jesse.brandeburg@intel.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"Allan, Bruce W" <bruce.w.allan@intel.com>,
"David S. Miller" <davem@davemloft.net>,
"Ronciak, John" <john.ronciak@intel.com>,
"Waskiewicz Jr, Peter P" <peter.p.waskiewicz.jr@intel.com>,
Koki Sanagi <sanagi.koki@jp.fujitsu.com>,
Kenji Kaneshige <kaneshige.kenji@jp.fujitsu.com>,
"e1000-devel@lists.sourceforge.net"
<e1000-devel@lists.sourceforge.net>
Subject: Re: [PATCH v2 0/3] e1000e,igb,ixgbe: add registers etc. printout code just before resetting adapters
Date: Thu, 25 Feb 2010 09:24:54 +0900 [thread overview]
Message-ID: <4B85C356.9090703@jp.fujitsu.com> (raw)
In-Reply-To: <97949e3e1002241136q70f55c97rafd79c2a5a19349c@mail.gmail.com>
Hi Chavey,
> I like the idea of adding debugging support. While using syslog does provide
> a "easier" way to get the output out, I am wondering if it would be
> worse the while
> to try to add a generic debug interface (via ethtool / netlink) that
> each driver would
> then support.
>
> If using syslog is the choosen way, then having the feature on by
> default may not
> be wanted.
I think these pritout messages are not only for debugging purpose but
a kind of error notification, for adapter resetting is error.
I prefer that these messages are always output wheter debugging mode is enabled
or not, but if it is not hoped to be always output to syslog, another place
(like a private ring buffer) is also acceptable.
Now I'm considering to output to private pring buffer.
Taku Izumi
next prev parent reply other threads:[~2010-02-25 0:25 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-22 5:45 [PATCH v2 0/3] e1000e,igb,ixgbe: add registers etc. printout code just before resetting adapters Taku Izumi
2010-01-22 5:48 ` [PATCH v2 1/3] e1000e: " Taku Izumi
2010-01-22 8:48 ` Taku Izumi
2010-02-19 19:19 ` Laurent Chavey
2010-01-22 5:49 ` [PATCH v2 2/3] igb: " Taku Izumi
2010-01-22 8:49 ` Taku Izumi
2010-01-22 5:50 ` [PATCH v2 3/3] ixgbe: " Taku Izumi
2010-01-22 8:50 ` Taku Izumi
2010-01-22 6:25 ` [PATCH v2 0/3] e1000e,igb,ixgbe: " Joe Perches
2010-01-22 8:46 ` Taku Izumi
2010-01-22 21:54 ` [PATCH v2 0/3] e1000e, igb, ixgbe: " Brandeburg, Jesse
2010-01-26 10:21 ` [PATCH v2 0/3] e1000e,igb,ixgbe: " Taku Izumi
2010-02-17 19:10 ` Brandeburg, Jesse
2010-02-17 19:32 ` Brandeburg, Jesse
2010-02-19 8:16 ` Taku Izumi
2010-02-19 11:20 ` Jeff Kirsher
2010-02-24 19:36 ` Laurent Chavey
2010-02-25 0:24 ` Taku Izumi [this message]
2010-02-25 0:30 ` Taku Izumi
2010-02-26 9:05 ` [PATCH v2 0/3] e1000e, igb, ixgbe: " Taku Izumi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B85C356.9090703@jp.fujitsu.com \
--to=izumi.taku@jp.fujitsu.com \
--cc=bruce.w.allan@intel.com \
--cc=chavey@google.com \
--cc=davem@davemloft.net \
--cc=e1000-devel@lists.sourceforge.net \
--cc=jeffrey.t.kirsher@intel.com \
--cc=jesse.brandeburg@intel.com \
--cc=john.ronciak@intel.com \
--cc=kaneshige.kenji@jp.fujitsu.com \
--cc=netdev@vger.kernel.org \
--cc=peter.p.waskiewicz.jr@intel.com \
--cc=sanagi.koki@jp.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.