Re: [ethtool PATCH] ethtool: Support n-tuple filter programming

[Jeff Garzik <jeff@garzik.org>]

On 02/04/2010 02:51 AM, Jeff Kirsher wrote:
> From: Peter Waskiewicz<peter.p.waskiewicz.jr@intel.com>
>
> Program underlying ethernet devices with n-tuple flow classification
> filters.
>
> This also adds a new flag to ethtool_flags, allowing n-tuple
> programming to be toggled using the set_flags call.
>
> Signed-off-by: Peter P Waskiewicz Jr<peter.p.waskiewicz.jr@intel.com>
> Signed-off-by: Jeff Kirsher<jeffrey.t.kirsher@intel.com>
> ---
>
>   ethtool-copy.h |   35 +++++++++++++
>   ethtool.c      |  156 ++++++++++++++++++++++++++++++++++++++++++++++++++++++--
>   2 files changed, 186 insertions(+), 5 deletions(-)

applied, but two problems remain:

1) you failed to document this in the man page.  I will expect a patch 
to ethtool.8.

2) you introduced a deviation from the upstream kernel ethtool.h:


--- ethtool-copy.h      2010-02-24 22:39:21.000000000 -0500
+++ ../net-next-2.6/include/linux/ethtool.h     2010-02-24 
22:14:43.000000000 -0500
@@ -389,8 +389,6 @@
  #define ETHTOOL_RXNTUPLE_ACTION_DROP -1
  };

-#define ETHTOOL_MAX_NTUPLE_LIST_ENTRY 1024
-#define ETHTOOL_MAX_NTUPLE_STRING_PER_ENTRY 14
  struct ethtool_rx_ntuple {
         __u32                                   cmd;
         struct ethtool_rx_ntuple_flow_spec      fs;