All of lore.kernel.org
 help / color / mirror / Atom feed
From: Heiko Schocher <hs@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] cmd_i2c.c: sorted commands alphabetically
Date: Thu, 25 Feb 2010 09:02:33 +0100	[thread overview]
Message-ID: <4B862E99.1080403@denx.de> (raw)
In-Reply-To: <1267037733-3375-4-git-send-email-fransmeulenbroeks@gmail.com>

Hello Frans,

First, thanks for your patches! They look good to me,
just one nitpicking comment.

Frans Meulenbroeks wrote:
> Signed-off-by: Frans Meulenbroeks <fransmeulenbroeks@gmail.com>
> ---
>  common/cmd_i2c.c |   10 +++++-----
>  1 files changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/common/cmd_i2c.c b/common/cmd_i2c.c
> index e54fc20..1dd4df3 100644
> --- a/common/cmd_i2c.c
> +++ b/common/cmd_i2c.c
> @@ -1302,13 +1302,14 @@ int do_i2c(cmd_tbl_t * cmdtp, int flag, int argc, char *argv[])
>  U_BOOT_CMD(
>  	i2c, 6, 1, do_i2c,
>  	"I2C sub-system",
> -	"speed [speed] - show or set I2C bus speed\n"
>  #if defined(CONFIG_I2C_MUX)
> -	"i2c bus [muxtype:muxaddr:muxchannel] - add a new bus reached over muxes\n"
> +	"bus [muxtype:muxaddr:muxchannel] - add a new bus reached over muxes\ni2c "
>  #endif  /* CONFIG_I2C_MUX */
> +	"crc32 chip address[.0, .1, .2] count - compute CRC32 checksum\n"
>  #if defined(CONFIG_I2C_MULTI_BUS)
>  	"i2c dev [dev] - show or set current I2C bus\n"
>  #endif  /* CONFIG_I2C_MULTI_BUS */
> +	"i2c loop chip address[.0, .1, .2] [# of objects] - looping read of device\n"
>  	"i2c md chip address[.0, .1, .2] [# of objects] - read from I2C device\n"
>  	"i2c mm chip address[.0, .1, .2] - write to I2C device (auto-incrementing)\n"
>  	"i2c mw chip address[.0, .1, .2] value [count] - write to I2C device (fill)\n"
> @@ -1316,11 +1317,10 @@ U_BOOT_CMD(
>  	"i2c crc32 chip address[.0, .1, .2] count - compute CRC32 checksum\n"

You should delete this here, otherwise it will show the
"i2c crc32" command twice in this help list.

>  	"i2c probe - show devices on the I2C bus\n"
>  	"i2c reset - re-init the I2C Controller\n"
> -	"i2c loop chip address[.0, .1, .2] [# of objects] - looping read of device"
>  #if defined(CONFIG_CMD_SDRAM)
> -	"\n"
> -	"i2c sdram chip - print SDRAM configuration information"
> +	"i2c sdram chip - print SDRAM configuration information\n"
>  #endif
> +	"i2c speed [speed] - show or set I2C bus speed"
>  );
>  
>  #if defined(CONFIG_I2C_MUX)

bye
Heiko
-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany

      parent reply	other threads:[~2010-02-25  8:02 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-02-24 18:55 [U-Boot] [PATCH] cmd_i2c.c: reduced subaddress length to 3 bytes Frans Meulenbroeks
2010-02-24 18:55 ` [U-Boot] [PATCH] cmd_bootm.c: made subcommand array static Frans Meulenbroeks
2010-02-24 18:55   ` [U-Boot] [PATCH] cmd_i2c.c: reworked subcommand handling Frans Meulenbroeks
2010-02-24 18:55     ` [U-Boot] [PATCH] cmd_i2c.c: sorted commands alphabetically Frans Meulenbroeks
2010-02-24 18:55       ` [U-Boot] [PATCH] cmd_i2c.c: added i2c read to memory function Frans Meulenbroeks
2010-02-25  8:03         ` Heiko Schocher
2010-02-25  8:02       ` Heiko Schocher [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4B862E99.1080403@denx.de \
    --to=hs@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.