From: Paolo Bonzini <pbonzini@redhat.com>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: Blue Swirl <blauwirbel@gmail.com>, qemu-devel@nongnu.org
Subject: [Qemu-devel] Re: [PATCH v2 2/2] get rid of hostregs_helper.h
Date: Thu, 25 Feb 2010 14:11:31 +0100 [thread overview]
Message-ID: <4B867703.8000609@redhat.com> (raw)
In-Reply-To: <20100225130427.GA10660@redhat.com>
On 02/25/2010 02:04 PM, Michael S. Tsirkin wrote:
>> Clobbering memory
>> > is not necessary since we are only caring about blocking assignments of
>> > "env", which is by definition in a register
>
> Then I think you should add that as a clobber. Otherwise what prevents the
> compiler from reordering this asm wrt assignments?
That old-style asms block scheduling of _anything_ across it (like
"barrier()" in the Linux kernel). So, it is actually slightly stricter
than what was there before.
I should have made clear in the commit message that this is the only
change wrt hostregs_helper.h.
Paolo
next prev parent reply other threads:[~2010-02-25 13:11 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-10 23:26 [Qemu-devel] [PATCH 0/2] simplify global register save/restore Paolo Bonzini
2010-02-10 23:26 ` [Qemu-devel] [PATCH 1/2] remove dead m68k global register definitions Paolo Bonzini
2010-02-10 23:26 ` [Qemu-devel] [PATCH 2/2] get rid of hostregs_helper.h Paolo Bonzini
2010-02-18 19:07 ` Blue Swirl
2010-02-18 20:25 ` [Qemu-devel] [PATCH v2 1/2] remove dead m68k definitions Paolo Bonzini
2010-02-18 20:25 ` [Qemu-devel] [PATCH v2 2/2] get rid of hostregs_helper.h Paolo Bonzini
2010-02-18 21:28 ` [Qemu-devel] " Blue Swirl
2010-02-25 11:40 ` Michael S. Tsirkin
2010-02-25 12:50 ` Paolo Bonzini
2010-02-25 13:04 ` Michael S. Tsirkin
2010-02-25 13:11 ` Paolo Bonzini [this message]
2010-02-13 17:58 ` [Qemu-devel] [PATCH 0/2] simplify global register save/restore Blue Swirl
2010-02-13 20:26 ` [Qemu-devel] " Paolo Bonzini
2010-02-13 20:57 ` Blue Swirl
2010-02-13 20:58 ` Paolo Bonzini
2010-02-26 11:30 ` [Qemu-devel] " Paul Brook
2010-02-26 13:05 ` Paolo Bonzini
2010-02-26 18:32 ` Paul Brook
2010-03-01 12:30 ` Paolo Bonzini
2010-03-01 14:02 ` Paul Brook
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B867703.8000609@redhat.com \
--to=pbonzini@redhat.com \
--cc=blauwirbel@gmail.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.