Re: [PATCH 2/2] rt2x00 : fix txdone implementation

[Alban Browaeys <prahal@yahoo.com>]

On 25/02/2010 02:58, Pavel Roskin wrote:
> Quoting Alban Browaeys <prahal@yahoo.com>:
>
>> Properly move to the headroom position in dma mapped skb. The hw extra
>> headroom is now taken into account.
>>
>> Signed-off-by: Alban Browaeys <prahal@yahoo.com>
> ...
>> -    rt2x00_set_field32(&word, TXD_W2_SD_PTR1,
>> -               skbdesc->skb_dma + rt2x00dev->ops->extra_tx_headroom);
>> +    rt2x00_set_field32(&word, TXD_W2_SD_PTR1, skbdesc->skb_dma
>> +               + rt2x00dev->ops->extra_tx_headroom);
>
> I think it's just a formatting change.  I would not mix formatting 
> changes with the real fixes.  I can understand reformatting code that 
> is also modified in some other way, but that's even a separate function.
>

Thank you. There was a real change (I did not meant for to reformat this 
line) but it got merged and I did not saw it.
I sent a new version of the patch without the first now uneeded change.

Best regards,
Alban