From: Gertjan van Wingerde <gwingerde@gmail.com>
To: prahal@yahoo.com, rt2x00 Users List <users@rt2x00.serialmonkey.com>
Cc: John Linville <linville@tuxdriver.com>,
Pavel Roskin <proski@gnu.org>,
linux-wireless <linux-wireless@vger.kernel.org>
Subject: Re: [rt2x00-users] [PATCH 2/2] rt2x00 : fix txdone implementation
Date: Thu, 25 Feb 2010 18:23:38 +0100 [thread overview]
Message-ID: <4B86B21A.1040906@gmail.com> (raw)
In-Reply-To: <4B868099.9000405@yahoo.com>
On 02/25/10 14:52, Alban Browaeys wrote:
> Properly move to the headroom position in dma mapped skb. The hw extra
> headroom is now taken into account.
>
> Signed-off-by: Alban Browaeys <prahal@yahoo.com>
> ---
> drivers/net/wireless/rt2x00/rt2800pci.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/net/wireless/rt2x00/rt2800pci.c
> b/drivers/net/wireless/rt2x00/rt2800pci.c
> index 46b06af..fbeff5c 100644
> --- a/drivers/net/wireless/rt2x00/rt2800pci.c
> +++ b/drivers/net/wireless/rt2x00/rt2800pci.c
> @@ -966,7 +966,7 @@ static void rt2800pci_txdone(struct rt2x00_dev
> *rt2x00dev)
> /* Check if we got a match by looking at WCID/ACK/PID
> * fields */
> txwi = (__le32 *)(entry->skb->data -
> - rt2x00dev->hw->extra_tx_headroom);
> + rt2x00dev->ops->extra_tx_headroom);
>
> rt2x00_desc_read(txwi, 1, &word);
> tx_wcid = rt2x00_get_field32(word, TXWI_W1_WIRELESS_CLI_ID);
This seems to be fixing an issue with your first patch. Please fold this fix into the first
patch and submit a single "working" patch.
---
Gertjan.
prev parent reply other threads:[~2010-02-25 17:23 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-25 13:52 [PATCH 2/2] rt2x00 : fix txdone implementation Alban Browaeys
2010-02-25 17:23 ` Gertjan van Wingerde [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B86B21A.1040906@gmail.com \
--to=gwingerde@gmail.com \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=prahal@yahoo.com \
--cc=proski@gnu.org \
--cc=users@rt2x00.serialmonkey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.