From mboxrd@z Thu Jan 1 00:00:00 1970 From: Patrick McHardy Subject: Re: [RFC PATCH net-next 1/5]IPv6:netfilter: defrag:Introduce net namespace Date: Thu, 25 Feb 2010 18:34:23 +0100 Message-ID: <4B86B49F.1010806@trash.net> References: <4B84E2A2.6020006@cn.fujitsu.com> <4B85321B.1090003@trash.net> <4B8660AD.7030308@cn.fujitsu.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit Cc: Alexey Dobriyan , netdev@vger.kernel.org To: Shan Wei Return-path: Received: from stinky.trash.net ([213.144.137.162]:38191 "EHLO stinky.trash.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933050Ab0BYReZ (ORCPT ); Thu, 25 Feb 2010 12:34:25 -0500 In-Reply-To: <4B8660AD.7030308@cn.fujitsu.com> Sender: netdev-owner@vger.kernel.org List-ID: Shan Wei wrote: > Patrick McHardy wrote, at 02/24/2010 10:05 PM: >> Shan Wei wrote: >>> Alexey Dobriyan wrote, at 02/24/2010 03:48 PM: >>>>> - .procname = "nf_conntrack_frag6_timeout", >>>>> - .data = &nf_init_frags.timeout, >>>>> - .maxlen = sizeof(unsigned int), >>>>> - .mode = 0644, >>>>> - .proc_handler = proc_dointvec_jiffies, >>>> Why are you removing sysctls? >>> Because, after introduced net namespace, we can use net->ipv6.frags to >>> manage IPv6 conntrack fragment queue instead of nf_init_frags. >>> And sysctls of ip6frag_low_thresh, ip6frag_time and ip6frag_high_thresh >>> also can control IPv6 conntrack fragment queue. >>> >>> So, private member of nf_init_frags becomes redundant, and remove these sysctls. >> You can't simply remove them without a warning, people might be >> using them. > > How to provide a warning to user? > How about handle these sysctl ABIs like this: > > s1) Retain these sysctls and refer .data to appropriate member of frags of init_net. > Take nf_conntrack_frag6_timeout for example, .data = &init_net.ipv6.frags.timeout. I'd suggest to refer to the proper namespace, check out net/netfilter/nf_conntrack_standalone.c for an example. > s2) When register sysctls of conntrack ipv6 protocol in nf_ct_l3proto_register_sysctl(), > print a waring like this. > "nf_conntrack_frag6_timeout and ip6frag_time, nf_conntrack_frag6_low_thresh and ip6frag_low_thresh, > nf_conntrack_frag6_high_thresh and ip6frag_high_thresh, the three sets are equivalent. > nf_conntrack_frag6_timeout is just an alias for ip6frag_time. The former Parameters of IPv6 conntrack > will be removed in the future, please use the latter ones of IPv6." > > s3) Describe these removable sysctl ABIs in Documentation/feature-removal-schedule.txt This sounds fine.