From: Randy Dunlap <randy.dunlap@oracle.com>
To: Linux Media Mailing List <linux-media@vger.kernel.org>
Cc: Mauro Carvalho Chehab <mchehab@redhat.com>,
Manu Abraham <abraham.manu@gmail.com>
Subject: [PATCH] media: fix precedence in dvb/frontends/tda665x
Date: Thu, 25 Feb 2010 14:57:46 -0800 [thread overview]
Message-ID: <4B87006A.4030303@oracle.com> (raw)
From: Randy Dunlap <randy.dunlap@oracle.com>
Fix precedence so that data is used correctly.
Fixes sparse warning:
drivers/media/dvb/frontends/tda665x.c:136:55: warning: right shift by bigger than source value
Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
Cc: Manu Abraham <abraham.manu@gmail.com>
---
drivers/media/dvb/frontends/tda665x.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- lnx-2633-spr.orig/drivers/media/dvb/frontends/tda665x.c
+++ lnx-2633-spr/drivers/media/dvb/frontends/tda665x.c
@@ -133,7 +133,7 @@ static int tda665x_set_state(struct dvb_
frequency += config->ref_divider >> 1;
frequency /= config->ref_divider;
- buf[0] = (u8) (frequency & 0x7f00) >> 8;
+ buf[0] = (u8) ((frequency & 0x7f00) >> 8);
buf[1] = (u8) (frequency & 0x00ff) >> 0;
buf[2] = 0x80 | 0x40 | 0x02;
buf[3] = 0x00;
next reply other threads:[~2010-02-25 22:59 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-25 22:57 Randy Dunlap [this message]
2010-02-26 7:45 ` [PATCH] media: fix precedence in dvb/frontends/tda665x Manu Abraham
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B87006A.4030303@oracle.com \
--to=randy.dunlap@oracle.com \
--cc=abraham.manu@gmail.com \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.