All of lore.kernel.org
 help / color / mirror / Atom feed
From: Cong Wang <amwang@redhat.com>
To: opurdila@ixiacom.com
Cc: David Miller <davem@davemloft.net>,
	Linux Kernel Network Developers <netdev@vger.kernel.org>,
	Linux Kernel Developers <linux-kernel@vger.kernel.org>,
	"Eric W. Biederman" <ebiederm@xmission.com>
Subject: Re: [net-next PATCH v5 2/3] sysctl: add proc_do_large_bitmap
Date: Fri, 26 Feb 2010 10:26:59 +0800	[thread overview]
Message-ID: <4B873173.80400@redhat.com> (raw)
In-Reply-To: <1267095756.12391.6.camel@Nokia-N900-42-11>

Octavian Purdila wrote:
>> I think one of them is enough, since we already chose commas, why
>> do we need to add spaces? If you have some strong reason to add it,
>> I have no objections.
>>
> 
> It is just for simpler implementation. It is actually harder to restrict the separator to only commas insted of allowing both spaces and commas, because I rely on functions used for the integer vector handling. 
> 
> Maybe I should change those functions to be more generic and thus to allow more stricter input, but I am not sure if its worth it. Isn't a more permissive input format desirable?

I think you should ask Eric, since he proposed using commas. :)
I am fine with either of them.

Thanks.

  reply	other threads:[~2010-02-26  2:23 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-02-25 11:02 [net-next PATCH v5 2/3] sysctl: add proc_do_large_bitmap Octavian Purdila
2010-02-26  2:26 ` Cong Wang [this message]
  -- strict thread matches above, loose matches on Subject: below --
2010-02-25  9:46 Octavian Purdila
2010-02-25  9:54 ` Cong Wang
2010-02-21 11:42 Octavian Purdila
2010-02-22  2:45 ` Cong Wang
2010-02-22 16:29   ` Octavian Purdila
2010-02-24  5:24     ` Cong Wang
2010-02-24  5:34       ` Cong Wang
2010-02-24 12:02       ` Octavian Purdila
2010-02-25  1:17         ` Cong Wang
2010-02-25  3:18           ` Cong Wang
2010-02-18 22:32 Octavian Purdila
2010-02-21  6:35 ` Cong Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4B873173.80400@redhat.com \
    --to=amwang@redhat.com \
    --cc=davem@davemloft.net \
    --cc=ebiederm@xmission.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=opurdila@ixiacom.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.