From: David Vrabel <david.vrabel@csr.com>
To: Ajay Kumar Gupta <ajay.gupta@ti.com>
Cc: linux-usb@vger.kernel.org, linux-omap@vger.kernel.org,
stern@rowland.harvard.edu, oliver@neukum.org
Subject: Re: [PATCH] musb: Add workqueue for URB giveback
Date: Fri, 26 Feb 2010 11:55:30 +0000 [thread overview]
Message-ID: <4B87B6B2.6010005@csr.com> (raw)
In-Reply-To: <1267180746-6773-1-git-send-email-ajay.gupta@ti.com>
Ajay Kumar Gupta wrote:
> Current musb host driver does the giveback of completed urb first and
> then start the next request. This is significantly affecting the streaming
> from an USB camera wherein we observe huge delay between the two IN tokens
> from musb host. This is due to the fact that UVC driver is doing decoding
> and further processing in giveback context.
>
> The patch tries to defer the giveback part to a workqueue and continues
> with the start of new request in completion path.
Suggest allocating a per-urb structure when a new URB is enqueued. This
structure contains the completion/giveback work item. This avoids
having to a) allocate memory on completion; b) create a second queue
structure.
David
--
David Vrabel, Senior Software Engineer, Drivers
CSR, Churchill House, Cambridge Business Park, Tel: +44 (0)1223 692562
Cowley Road, Cambridge, CB4 0WZ http://www.csr.com/
Member of the CSR plc group of companies. CSR plc registered in England and Wales, registered number 4187346, registered office Churchill House, Cambridge Business Park, Cowley Road, Cambridge, CB4 0WZ, United Kingdom
prev parent reply other threads:[~2010-02-26 11:56 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-26 10:39 [PATCH] musb: Add workqueue for URB giveback Ajay Kumar Gupta
2010-02-26 11:03 ` Oliver Neukum
[not found] ` <201002261203.27619.oliver-GvhC2dPhHPQdnm+yROfE0A@public.gmane.org>
2010-02-26 11:20 ` Gupta, Ajay Kumar
[not found] ` <19F8576C6E063C45BE387C64729E7394044DB7A964-/tLxBxkBPtCIQmiDNMet8wC/G2K4zDHf@public.gmane.org>
2010-02-26 11:33 ` Oliver Neukum
2010-02-26 12:19 ` Gupta, Ajay Kumar
2010-02-26 11:33 ` Laurent Pinchart
[not found] ` <201002261233.46872.laurent.pinchart-ryLnwIuWjnjg/C1BVhZhaw@public.gmane.org>
2010-02-26 12:24 ` Gupta, Ajay Kumar
2010-02-26 11:55 ` David Vrabel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B87B6B2.6010005@csr.com \
--to=david.vrabel@csr.com \
--cc=ajay.gupta@ti.com \
--cc=linux-omap@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=oliver@neukum.org \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.