[Qemu-devel] Re: [PATCH 4/4] kbd keds: vnc

[Gerd Hoffmann <kraxel@redhat.com>]

   Hi,

>> +    int caps, num;
>
> I think it is clearer to use a bool.
>
>     bool caps = ledstate&  QEMU_CAPS_LOCK_LED;

Indeed.

>> +    if (vs->modifiers_state[0x3a] != caps) {
>> +        vs->modifiers_state[0x3a] = caps;
>
> modifiers_state type needs to go from uint8_t to bool.  It simplifies
> lots of !!foo around.  But the change is independent of this series.

But mixing uin8_t and bool doesn't look sane to me.  So I think I stay 
with uin8_t to match modifiers_state type.

cheers,
   Gerd