From: Patrick McHardy <kaber@trash.net>
To: Alexey Dobriyan <adobriyan@gmail.com>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [PATCH] nfnetlink_log: fix silly refcount leak
Date: Fri, 26 Feb 2010 17:49:11 +0100 [thread overview]
Message-ID: <4B87FB87.1090004@trash.net> (raw)
In-Reply-To: <20100224191847.GA3390@core2>
Alexey Dobriyan wrote:
> Quick fix for memory/module refcount leak.
> Reference count of listener instance never reaches 0.
>
> Start/stop of ulogd2 is enough to trigger this bug!
>
> Now, refcounting there looks very fishy in particular this code:
>
> if (!try_module_get(THIS_MODULE)) {
> ...
>
> and creation of listener instance with refcount 2,
> so it may very well be ripped and redone. :-)
Applied, thanks Alexey.
prev parent reply other threads:[~2010-02-26 16:49 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-24 19:18 [PATCH] nfnetlink_log: fix silly refcount leak Alexey Dobriyan
2010-02-26 16:49 ` Patrick McHardy [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B87FB87.1090004@trash.net \
--to=kaber@trash.net \
--cc=adobriyan@gmail.com \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.