From: Randy Dunlap <randy.dunlap@oracle.com>
To: Alex Deucher <alexdeucher@gmail.com>
Cc: Dave Airlie <airlied@gmail.com>,
Randy Dunlap <randy.dunlap@oracle.com>,
lkml <linux-kernel@vger.kernel.org>,
David Airlie <airlied@linux.ie>
Subject: Re: [PATCH] drm: fix char constant (sparse warning)
Date: Mon, 01 Mar 2010 09:15:45 -0800 [thread overview]
Message-ID: <4B8BF641.1050109@oracle.com> (raw)
In-Reply-To: <a728f9f91003010906x6103bee9pe72a28f63f04b984@mail.gmail.com>
On 03/01/10 09:06, Alex Deucher wrote:
> On Mon, Mar 1, 2010 at 1:01 AM, Dave Airlie <airlied@gmail.com> wrote:
>> On Thu, Feb 25, 2010 at 8:27 AM, Randy Dunlap <randy.dunlap@oracle.com> wrote:
>>> From: Randy Dunlap <randy.dunlap@oracle.com>
>>>
>>> Fix radeon/atombios.h sparse warning (24 times):
>>>
>>> drivers/gpu/drm/radeon/atombios.h:4091:63: error: Bad character constant
>>
>> We get this file from AMD pretty much as-is and I hate deviating it as it
>> causes merge issues. Alex any change you can get this fixed upstream?
Ah, thanks for that info.
>>
>
> I can try.
>
> Alex
OK, thanks.
>> Dave.
>>
>>>
>>> Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
>>> Cc: David Airlie <airlied@linux.ie>
>>> ---
>>> drivers/gpu/drm/radeon/atombios.h | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> --- linux-2.6.33-rc8.orig/drivers/gpu/drm/radeon/atombios.h
>>> +++ linux-2.6.33-rc8/drivers/gpu/drm/radeon/atombios.h
>>> @@ -4088,7 +4088,7 @@ typedef struct _SW_I2C_IO_DATA_PARAMETER
>>> #define SW_I2C_CNTL_WRITE1BIT 6
>>>
>>> /* ==============================VESA definition Portion=============================== */
>>> -#define VESA_OEM_PRODUCT_REV '01.00'
>>> +#define VESA_OEM_PRODUCT_REV "01.00"
>>> #define VESA_MODE_ATTRIBUTE_MODE_SUPPORT 0xBB /* refer to VBE spec p.32, no TTY support */
>>> #define VESA_MODE_WIN_ATTRIBUTE 7
>>> #define VESA_WIN_SIZE 64
>>> --
--
~Randy
prev parent reply other threads:[~2010-03-01 17:17 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-24 22:27 [PATCH] drm: fix char constant (sparse warning) Randy Dunlap
2010-03-01 6:01 ` Dave Airlie
2010-03-01 17:06 ` Alex Deucher
2010-03-01 17:15 ` Randy Dunlap [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B8BF641.1050109@oracle.com \
--to=randy.dunlap@oracle.com \
--cc=airlied@gmail.com \
--cc=airlied@linux.ie \
--cc=alexdeucher@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.