From: "H. Peter Anvin" <hpa@zytor.com>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: Wu Fengguang <fengguang.wu@intel.com>,
Xiaotian Feng <xtfeng@gmail.com>,
Sachin Sant <sachinp@in.ibm.com>, Yinghai Lu <yinghai@kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
Ingo Molnar <mingo@redhat.com>, "x86@kernel.org" <x86@kernel.org>
Subject: Re: 2.6.33-git6 boot failure[x86_64] (WARN: at arch/x86/mm/ioremap.c:111)
Date: Mon, 01 Mar 2010 10:16:26 -0800 [thread overview]
Message-ID: <4B8C047A.9030406@zytor.com> (raw)
In-Reply-To: <alpine.LFD.2.00.1003011728450.4245@localhost.localdomain>
On 03/01/2010 08:31 AM, Thomas Gleixner wrote:
> On Mon, 1 Mar 2010, Wu Fengguang wrote:
> Ah walk_system_ram_range() is actually doing almost the same alignment
>> check as the removed x86 page_is_ram(), except that it calls func()
>> with len=0. This happens when page_is_ram(cffa3000) is called.
>>
>> walk_system_ram_range():
>> pfn = (unsigned long)(res.start >> PAGE_SHIFT);
>> len = (unsigned long)((res.end + 1 - res.start) >> PAGE_SHIFT);
>> ret = (*func)(pfn, len, arg);
>>
>> The following patch should fix the problem.
>
> Right, that should fix it. Though I wonder whether we should warn
> prominently about non page aligned e820 mapping entries.
>
Pointless. It's way too common, and in the case of the lowmem region,
probably correct.
-hpa
next prev parent reply other threads:[~2010-03-01 18:17 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-01 4:34 2.6.33-git6 boot failure[x86_64] (WARN: at arch/x86/mm/ioremap.c:111) Sachin Sant
2010-03-01 6:18 ` Xiaotian Feng
2010-03-01 8:28 ` Sachin Sant
2010-03-01 8:38 ` Xiaotian Feng
2010-03-01 10:42 ` Thomas Gleixner
2010-03-01 13:55 ` Wu Fengguang
2010-03-01 16:31 ` Thomas Gleixner
2010-03-01 18:16 ` H. Peter Anvin [this message]
2010-03-01 19:00 ` [tip:x86/mm] resource: Fix generic page_is_ram() for partial RAM pages tip-bot for Wu Fengguang
2010-03-01 23:45 ` Yinghai Lu
2010-03-09 13:12 ` Wu Fengguang
2010-03-01 22:47 ` 2.6.33-git6 boot failure[x86_64] (WARN: at arch/x86/mm/ioremap.c:111) john stultz
2010-03-02 19:33 ` [tip:x86/mm] resource: Fix broken indentation tip-bot for H. Peter Anvin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B8C047A.9030406@zytor.com \
--to=hpa@zytor.com \
--cc=fengguang.wu@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=sachinp@in.ibm.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
--cc=xtfeng@gmail.com \
--cc=yinghai@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.