From: Mauro Carvalho Chehab <mchehab@infradead.org>
To: Devin Heitmueller <dheitmueller@kernellabs.com>
Cc: Hans Verkuil <hverkuil@xs4all.nl>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Linux Media Mailing List <linux-media@vger.kernel.org>
Subject: Re: How do private controls actually work?
Date: Mon, 01 Mar 2010 19:29:02 -0300 [thread overview]
Message-ID: <4B8C3FAE.6060509@infradead.org> (raw)
In-Reply-To: <829197381003010220w57248cb2l636a75d5bf4b19c1@mail.gmail.com>
Hi Devin,
Devin Heitmueller wrote:
> On Mon, Mar 1, 2010 at 4:58 AM, Hans Verkuil <hverkuil@xs4all.nl> wrote:
>> New private controls should not use V4L2_CID_PRIVATE_BASE at all. That
>> mechanism was a really bad idea. Instead a new control should be added to
>> the appropriate control class and with a offset >= 0x1000. See for example
>> the CX2341X private controls in videodev2.h.
The better is to create a device-specific control, if the parameter you want
to control is really specific to just one chip family. Otherwise, just add a
new "common" control to the API.
>
> http://kernellabs.com/hg/~dheitmueller/em28xx-test/rev/a7d50db75420
FYI, v42-apps were moved to a separate tree.
--
Cheers,
Mauro
next prev parent reply other threads:[~2010-03-01 22:29 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-01 2:56 How do private controls actually work? Devin Heitmueller
2010-03-01 8:57 ` Laurent Pinchart
2010-03-01 9:07 ` Devin Heitmueller
2010-03-01 9:58 ` Hans Verkuil
2010-03-01 10:20 ` Devin Heitmueller
2010-03-01 11:18 ` Hans Verkuil
2010-03-01 22:29 ` Mauro Carvalho Chehab [this message]
2010-03-02 20:28 ` Hans Verkuil
2010-03-02 20:42 ` Devin Heitmueller
2010-03-02 20:56 ` Hans Verkuil
2010-03-02 21:23 ` Mauro Carvalho Chehab
2010-03-03 1:57 ` Andy Walls
2010-03-03 3:25 ` Mauro Carvalho Chehab
2010-03-01 11:47 ` Andy Walls
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B8C3FAE.6060509@infradead.org \
--to=mchehab@infradead.org \
--cc=dheitmueller@kernellabs.com \
--cc=hverkuil@xs4all.nl \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-media@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.