From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752067Ab0CBJ2j (ORCPT ); Tue, 2 Mar 2010 04:28:39 -0500 Received: from compulab.co.il ([67.18.134.219]:40090 "EHLO compulab.co.il" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751363Ab0CBJ2h (ORCPT ); Tue, 2 Mar 2010 04:28:37 -0500 Message-ID: <4B8CDA64.4070504@compulab.co.il> Date: Tue, 02 Mar 2010 11:29:08 +0200 From: Denis Turischev User-Agent: Thunderbird 2.0.0.23 (X11/20090817) MIME-Version: 1.0 To: Len Brown CC: Mike Rapoport , David Brownell , Samuel Ortiz , LKML Subject: Re: [PATCH v3 3/3] gpio: add Intel SCH GPIO controller driver References: <4B73DAEE.5080400@compulab.co.il> <4B7C0DC3.3060907@compulab.co.il> <4B812C21.8000602@compulab.co.il> <201002211112.48527.david-b@pacbell.net> <4B84CC0E.5060203@compulab.co.il> <4B8CB370.5080903@compulab.co.il> In-Reply-To: <4B8CB370.5080903@compulab.co.il> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-ACL-Warn: { X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - compulab.site5.com X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - compulab.co.il X-Source: X-Source-Args: X-Source-Dir: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Mike Rapoport wrote: > Len Brown wrote: >>> I've looked at two x86 drivers in drivers/gpiolib (cs5535 and langwell) and >>> there's no treatment of ACPI in either of them. Since SCH is defined by Intel >>> as "embedded" product, having a GPIO driver for it seems logical even despite >>> problems you mention. >> FWIW >> I believe that Langwell is used only in products without an ACPI BIOS. >> >> Poulsbo, OTOH, is used in zillions of netbooks running Windows XP. >> I don't know what a cs5535 is. > > The cs5535 is AMD Geode LX companion chip which is used with ACPI BIOS > as well. > >> cheers, >> Len Brown, Intel Open Source Technology Center >> > > I'm really not an ACPI expert too, but as I see in LDD3 "...the role of a device driver is providing mechanism, not policy". HW manufacturer must warn users if some GPIOs may conflict with ACPI, and it is user`s responsibility to use the GPIOs in proper way. Denis