From: Gilles Chanteperdrix <gilles.chanteperdrix@xenomai.org>
To: Jan Kiszka <jan.kiszka@domain.hid>
Cc: Xenomai core <Xenomai-core@domain.hid>
Subject: Re: [Xenomai-core] [Xenomai-git] Jan Kiszka : Native: Fix return code of in-kernel rt_cond_wait[_until]
Date: Tue, 02 Mar 2010 14:30:34 +0100 [thread overview]
Message-ID: <4B8D12FA.6040807@domain.hid> (raw)
In-Reply-To: <4B8D11A6.9070400@domain.hid>
Jan Kiszka wrote:
> Gilles Chanteperdrix wrote:
>> Ok for returning -EINTR, it is documented. Kernel-space is not so
>> different from user-space, rt_task_unblock could wake-up a kernel-space
>> task blocked in a call to rt_cond_wait.
>>
>> However, if the epilogue returns an error, we must return it.
>>
>
> OK for this. Pushed an update, but I also modified it further to avoid
> returning without the mutex lock unless that one is also failing. Maybe
> in-kernel POSIX requires the same fix, will check.
Still not OK. You should reacquire the mutex only if the error is 0,
-ETIMEDOUT or -EINTR. With any other error, we do not know if we can
call the epilogue safely.
--
Gilles.
next prev parent reply other threads:[~2010-03-02 13:30 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <E1NmR5I-0003k9-N5@domain.hid>
2010-03-02 12:23 ` [Xenomai-core] [Xenomai-git] Jan Kiszka : Native: Fix return code of in-kernel rt_cond_wait[_until] Gilles Chanteperdrix
2010-03-02 12:28 ` Jan Kiszka
2010-03-02 12:29 ` Jan Kiszka
2010-03-02 12:32 ` Gilles Chanteperdrix
2010-03-02 12:33 ` Gilles Chanteperdrix
2010-03-02 12:43 ` Jan Kiszka
2010-03-02 12:48 ` Gilles Chanteperdrix
2010-03-02 12:59 ` Jan Kiszka
2010-03-02 13:04 ` Gilles Chanteperdrix
2010-03-02 13:24 ` Jan Kiszka
2010-03-02 13:30 ` Gilles Chanteperdrix [this message]
2010-03-02 13:34 ` Jan Kiszka
2010-03-02 13:38 ` Gilles Chanteperdrix
2010-03-02 13:44 ` Jan Kiszka
2010-03-02 13:46 ` Gilles Chanteperdrix
2010-03-02 14:00 ` Jan Kiszka
2010-03-02 14:04 ` Gilles Chanteperdrix
2010-03-02 14:08 ` Jan Kiszka
2010-03-02 14:15 ` Gilles Chanteperdrix
2010-03-02 14:25 ` Gilles Chanteperdrix
2010-03-02 14:43 ` Jan Kiszka
2010-03-02 13:40 ` Jan Kiszka
2010-03-02 13:44 ` Gilles Chanteperdrix
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B8D12FA.6040807@domain.hid \
--to=gilles.chanteperdrix@xenomai.org \
--cc=Xenomai-core@domain.hid \
--cc=jan.kiszka@domain.hid \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.