From: "H. Peter Anvin" <hpa@zytor.com>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: "H. Peter Anvin" <hpa@linux.kernel.org>,
"Ingo Molnar" <mingo@elte.hu>,
"Thomas Gleixner" <tglx@linutronix.de>,
"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
"Sachin Sant" <sachinp@in.ibm.com>,
"KAMEZAWA Hiroyuki" <kamezawa.hiroyu@jp.fujitsu.com>,
"Wu Fengguang" <fengguang.wu@intel.com>,
"Ian Campbell" <ian.campbell@citrix.com>,
"Alok Kataria" <akataria@vmware.com>,
"Jeremy Fitzhardinge" <jeremy@goop.org>,
"Pasi Kärkkäinen" <pasik@iki.fi>
Subject: Re: [GIT PULL] x86/mm fixes
Date: Tue, 02 Mar 2010 11:09:41 -0800 [thread overview]
Message-ID: <4B8D6275.30100@zytor.com> (raw)
In-Reply-To: <alpine.LFD.2.00.1003021038410.3616@localhost.localdomain>
On 03/02/2010 10:39 AM, Linus Torvalds wrote:
>
>
> On Tue, 2 Mar 2010, H. Peter Anvin wrote:
>> + pfn = (res.start + PAGE_SIZE - 1) >> PAGE_SHIFT;
>> + end_pfn = (res.end + 1) >> PAGE_SHIFT;
>> + if (end_pfn > pfn)
>> + ret = (*func)(pfn, end_pfn - pfn, arg);
>> if (ret)
>> break;
>> res.start = res.end + 1;
>
> What kind of messed-up indentation is that? We don't use 4-char indents.
>
> Linus
Sorry, you're right. I have to admit I didn't even see that aspect of
the patch.
I'll add a reformatting patch and update the branch, if you want.
-hpa
next prev parent reply other threads:[~2010-03-02 19:19 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <201003020010.o220Ax3Z025848@hera.kernel.org>
2010-03-02 18:39 ` [GIT PULL] x86/mm fixes Linus Torvalds
2010-03-02 19:09 ` H. Peter Anvin [this message]
2010-03-02 19:31 ` H. Peter Anvin
2010-03-03 2:08 ` Wu Fengguang
2010-03-03 17:10 ` Linus Torvalds
2010-03-04 0:44 ` Wu Fengguang
2010-03-04 15:03 ` Peter Zijlstra
2010-03-05 1:07 ` Wu Fengguang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B8D6275.30100@zytor.com \
--to=hpa@zytor.com \
--cc=akataria@vmware.com \
--cc=fengguang.wu@intel.com \
--cc=hpa@linux.kernel.org \
--cc=ian.campbell@citrix.com \
--cc=jeremy@goop.org \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=pasik@iki.fi \
--cc=sachinp@in.ibm.com \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.