Re: [Xenomai-core] Posix mutex unit test fails on git head

[Jan Kiszka <jan.kiszka@domain.hid>]

[-- Attachment #1: Type: text/plain, Size: 2186 bytes --]

Gilles Chanteperdrix wrote:
> Gilles Chanteperdrix wrote:
>> Jan Kiszka wrote:
>>> Gilles Chanteperdrix wrote:
>>>> Jan Kiszka wrote:
>>>>> Jan Kiszka wrote:
>>>>>> Gilles,
>>>>>>
>>>>>> can you (or someone else) confirm this:
>>>>>>
>>>>>> # mutex-torture-posix
>>>>>> simple_wait
>>>>>> simple mutex_lock 1: 1 (Operation not permitted)
>>>>>>
>>>>>> I'm on a x86_64 target (2.6.32.8 with latest I-pipe), Xenomai is
>>>>>> unpatched git head.
>>>>>>
>>>>> Looks like a bug in the test case: We do not wrap sched_setscheduler
>>>>> which it uses, and my config does not auto-shadow main. Fix will follow.
>>>> The test works here, but fails in cond_signaler, mutex_lock 2, just
>>>> checked out v2.5.1 to see if we already had the bug.
>>>>
>>> Weird. Works for me with this fix:
>>>
>>> diff --git a/src/testsuite/unit/mutex-torture.c b/src/testsuite/unit/mutex-torture.c
>>> index 70bda14..ebdd4f2 100644
>>> --- a/src/testsuite/unit/mutex-torture.c
>>> +++ b/src/testsuite/unit/mutex-torture.c
>>> @@ -657,7 +657,7 @@ int main(void)
>>>  	/* Set scheduling parameters for the current process */
>>>  #ifdef XENO_POSIX
>>>  	sparam.sched_priority = 2;
>>> -	sched_setscheduler(0, SCHED_FIFO, &sparam);
>>> +	pthread_setschedparam(pthread_self(), SCHED_FIFO, &sparam);
>>>  #else /* __NATIVE_SKIN__ */
>>>  	rt_task_shadow(&main_tid, "main_task", 2, 0);
>>>  #endif /* __NATIVE_SKIN__ */
>>>
>>>
>>> # mutex-torture-posix
>>> simple_wait
>>> recursive_wait
>>> errorcheck_wait
>>> mode_switch
>>> pi_wait
>>> lock_stealing
>>> lock_stealing mutex_trylock: not supported
>>> simple_condwait
>>> recursive_condwait
>>> cond_signaler, mutex_lock 2 waited 0.854 us
>> No, that is a bug. We should have waited 10ms, and we wait less than a us.
>>
> 
> Ok. Should be fixed by commit af93ec87f975b387243127090b578d57922b38dc.
> The bug was on the same goddamn pass as the one we are trying to fix to
> return proper return values to user-space.
> 

Yes, looks good!

I've hacked up some additional (basic) test cases for times mutex and
cond waiting, and now I'm looking into the posix side of that infamous
workaround.

Jan


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 257 bytes --]