From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jeff Garzik <jeff@garzik.org>
Subject: Re: [Patch 2/3] chcli cleanup: gcc warning
Date: Wed, 03 Mar 2010 06:45:41 -0500
Message-ID: <4B8E4BE5.1050205@garzik.org>
References: <20100302190844.60b75d93@redhat.com>	<4B8DC6F0.7080703@garzik.org> <20100302194150.30eddb80@redhat.com>
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Return-path: <hail-devel-owner@vger.kernel.org>
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=gamma;
        h=domainkey-signature:received:received:sender:message-id:date:from
         :user-agent:mime-version:to:cc:subject:references:in-reply-to
         :content-type:content-transfer-encoding;
        bh=p7H1wQIecsHKk8PWJKyVBxN2fQD1GE0bSXOnygwuCdY=;
        b=DLff5cczYfVLlzzmeKTMHbhEi+KLn3G+YHS+VjnpyJ7l+Pm55vaoaz3UYCL+BJMWDs
         XLknmBUgOGsWCL8V6THJnOPt4q7TiSbSZ0ec0DrSSScpg9jNqUmn9eznUpb4lhdqy3Jk
         1f2riImfvT0Eim0wbts5mk3ASFFfeGnOiWYrI=
In-Reply-To: <20100302194150.30eddb80@redhat.com>
Sender: hail-devel-owner@vger.kernel.org
List-ID: <hail-devel.vger.kernel.org>
Content-Type: text/plain; charset="us-ascii"; format="flowed"
To: Pete Zaitcev <zaitcev@redhat.com>
Cc: Project Hail List <hail-devel@vger.kernel.org>

On 03/02/2010 09:41 PM, Pete Zaitcev wrote:
> On Tue, 02 Mar 2010 21:18:24 -0500
> Jeff Garzik<jeff@garzik.org>  wrote:
>
>> Note that your mailer is mangling patches via "quoted-printable":
>
> No, it does not. Look at this:
>
> [zaitcev@lembas ~]$ grep fstat Mail/inbox/*
> Mail/inbox/10891:# diffstat add_function.patch hub_revision_ACPI_modes.patch
> Mail/inbox/15830:-      rc =3D fstat(fd,&stat);
> Mail/inbox/15830:+      rc =3D fstat(fd,&st);
> Mail/inbox/15833:-      rc = fstat(fd,&stat);
> Mail/inbox/15833:+      rc = fstat(fd,&statb);
>
>> Content-Type: text/plain; charset=UTF-8
>> Content-Transfer-Encoding: quoted-printable
>> [...]
>> =20
>> -	rc =3D fstat(fd,&stat);
>> +	rc =3D fstat(fd,&st);
>>    	if (rc) {
>
> Clearly, its your own message you are complaining about, not mine,
> because my patch changed the variable to 'statb' (and it's not
> corrupt, see above grep), while your patch changed to it to 'st'.
> "My mailer" did not even touch it. Heck, I did not even see that
> message (although I did a git pull to see if the "note" you promised
> was attached to the changelog).

I manually changed s/statb/st/ using vi directly on the Berkeley mbox 
file.  Don't get confused by that.

Ignore the variable name change and look at the quoted-printable 
artifacts "=3D", "=20", etc...

	Jeff