All of lore.kernel.org
 help / color / mirror / Atom feed
From: viresh.kumar@st.com (Viresh KUMAR)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2] CLKDEV: return from clk_find as soon as we get	maching clk
Date: Wed, 03 Mar 2010 17:31:23 +0530	[thread overview]
Message-ID: <4B8E4F93.6030200@st.com> (raw)
In-Reply-To: <20100303103342.GA7952@pengutronix.de>

Hello,

On 3/3/2010 4:03 PM, Uwe Kleine-K?nig wrote:
> On Wed, Mar 03, 2010 at 12:18:27PM +0530, Viresh KUMAR wrote:
>> clk_find function looks for clock with matching dev_id and con_id.
>> We should return from clk_find as soon as we get a clock with matching dev_id
>> and con_id. This can be done by comparing variable "match" with 3.
>>
>> v2:
>> 	- remove if (match == 0), check.
>> 	- move match==3 in if (match > best) condition
> can you take the changes since v1 out of the changelog.  They usually go
> ...

OK.

>>
>> Signed-off-by: Viresh Kumar <viresh.kumar@st.com>
>> ---
> Does this mean you understood Russell's hint?

Truly speaking i didn't get it completely, but i think Russsell is 
referring to multiple return points from a function.

Russell, Am I getting it correctly ?

> Did you test the differences your patch results in for the generated
> code?

I think they are essentially same, we now just have a single return point
in the new patch.

regards,
viresh

  reply	other threads:[~2010-03-03 12:01 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-03-03  6:48 [PATCH v2] CLKDEV: return from clk_find as soon as we get maching clk Viresh KUMAR
2010-03-03 10:33 ` Uwe Kleine-König
2010-03-03 12:01   ` Viresh KUMAR [this message]
2010-03-04  9:29     ` Uwe Kleine-König

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4B8E4F93.6030200@st.com \
    --to=viresh.kumar@st.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.