From: Richard Henderson <rth@twiddle.net>
To: Maxim Kuvyrkov <maxim@codesourcery.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 3/4] Fix signal handling for ColdFire
Date: Wed, 03 Mar 2010 14:17:53 +0100 [thread overview]
Message-ID: <4B8E6181.7010104@twiddle.net> (raw)
In-Reply-To: <4B8C1660.5080009@codesourcery.com>
> + float64 sc_fpregs[2]; /* room for two fp registers */
...
> - int f_fpcntl[3];
> - int f_fpregs[8*3];
> + uint32_t f_fpcntl[3];
> + float64 f_fpregs[8];
Surely these float64 uses are incorrect. The kernel uses 3*int
at both of these places, which matches up with the 96-bit values
in the regular m68k fpu.
r~
next prev parent reply other threads:[~2010-03-03 13:19 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-01 19:19 [Qemu-devel] [PATCH 0/4] Support NPTL support for ColdFire and related fixes Maxim Kuvyrkov
2010-03-01 19:31 ` [Qemu-devel] [PATCH 1/4] Add NPTL support for ColdFire Maxim Kuvyrkov
2010-03-01 19:32 ` [Qemu-devel] [PATCH 2/4] Handle SIGKILL and SIGCHLD Maxim Kuvyrkov
2010-03-01 19:32 ` [Qemu-devel] [PATCH 3/4] Fix signal handling for ColdFire Maxim Kuvyrkov
2010-03-03 13:17 ` Richard Henderson [this message]
2010-03-03 13:36 ` Maxim Kuvyrkov
2010-03-01 19:33 ` [Qemu-devel] [PATCH 4/4] Define MMAP_SHIFT " Maxim Kuvyrkov
2010-05-21 9:45 ` [Qemu-devel] {PING}[PATCH 0/4] Support NPTL support for ColdFire and related fixes Maxim Kuvyrkov
2010-07-15 8:51 ` [Qemu-devel] {PING^2} [PATCH " Maxim Kuvyrkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B8E6181.7010104@twiddle.net \
--to=rth@twiddle.net \
--cc=maxim@codesourcery.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.