All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Hellstrom <thomas@shipmail.org>
To: Luca Barbieri <luca.barbieri@gmail.com>
Cc: "Jerome Glisse" <jglisse@redhat.com>,
	"Michel Dänzer" <michel@daenzer.net>,
	dri-devel@lists.sourceforge.net
Subject: Re: [RFC] drm/ttm: add pool wc/uc page allocator
Date: Wed, 03 Mar 2010 15:19:43 +0100	[thread overview]
Message-ID: <4B8E6FFF.3000708@shipmail.org> (raw)
In-Reply-To: <ff13bc9a1003030603i726379b3h27f1142686dbbc05@mail.gmail.com>

Luca Barbieri wrote:
>> ^^^ Luca, I've never seen this show up high on a profile (yet). Do you see
>> that with Nouveau? I used to have an rb-tree implementation of drm_mm_xxx
>> lying around, but I didn't use it because I didn't have a case where it
>> showed up?
>>     
>
> Yes, before I did userspace allocation, in doom3 profiles,
> get_unmapped_area and function called by it (all coming from sys_mmap)
> consumed around 10% of the time.
>
> Note that this is not DRM-specific code, but rather the generic Linux
> code for finding free virtual address space, which walks over all the
> vmas in the process and, in the default x86 variant, does an rb-tree
> lookup for each vma!
>   

Ah, OK. I thought this was the drm linear search for device address 
space for each bo.

> It could be fixed by either in the kernel with better data structures
> and algorithms or in userspace by using MAP_FIXED.
> However, this will still leave significant kernel overhead (e.g. just
> drm_mm_search_free_in_range takes 1%).
>   

/Thomas


------------------------------------------------------------------------------
Download Intel&#174; Parallel Studio Eval
Try the new software tools for yourself. Speed compiling, find bugs
proactively, and fine-tune applications for parallel performance.
See why Intel Parallel Studio got high marks during beta.
http://p.sf.net/sfu/intel-sw-dev
--

  reply	other threads:[~2010-03-03 14:19 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-02-28 21:30 [RFC] drm/ttm: add pool wc/uc page allocator Pauli Nieminen
2010-03-01 22:32 ` Pauli Nieminen
2010-03-02 10:56   ` Michel Dänzer
     [not found]     ` <4B8CFB1B.1020806@shipmail.org>
2010-03-03 12:13       ` Pauli Nieminen
2010-03-03 12:47         ` Luca Barbieri
2010-03-03 13:23           ` Thomas Hellstrom
2010-03-03 14:03             ` Luca Barbieri
2010-03-03 14:19               ` Thomas Hellstrom [this message]
2010-03-03 13:33   ` Jerome Glisse
2010-03-03 14:23     ` Pauli Nieminen
2010-03-03 14:50       ` Jerome Glisse
2010-03-03 15:46         ` Pauli Nieminen
2010-03-03 16:02           ` Jerome Glisse

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4B8E6FFF.3000708@shipmail.org \
    --to=thomas@shipmail.org \
    --cc=dri-devel@lists.sourceforge.net \
    --cc=jglisse@redhat.com \
    --cc=luca.barbieri@gmail.com \
    --cc=michel@daenzer.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.