From: Geoff Levand <geoffrey.levand@am.sony.com>
To: "Levand, Geoffrey" <Geoffrey.Levand@am.sony.com>
Cc: Andy Shevchenko <andy.shevchenko@gmail.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Andy Shevchenko <ext-andriy.shevchenko@nokia.com>
Subject: Re: [PATCHv2] drivers: net: optimize hex2bin()
Date: Wed, 3 Mar 2010 14:02:46 -0800 [thread overview]
Message-ID: <4B8EDC86.20806@am.sony.com> (raw)
In-Reply-To: <4B8D370A.4030609@am.sony.com>
Hi,
On 03/02/2010 08:04 AM, Levand, Geoffrey wrote:
> On 03/01/2010 11:59 PM, Andy Shevchenko wrote:
>> Optimize hex2bin() function used in ps3_gelic_wireless.c. It requires to have
>> hex_to_bin() implementation introduced by starter patch [1] in series.
>>
>> [1] http://patchwork.kernel.org/patch/81224/
>>
>> Signed-off-by: Andy Shevchenko <ext-andriy.shevchenko@nokia.com>
>> Cc: Geoff Levand <geoffrey.levand@am.sony.com>
>> ---
>> drivers/net/ps3_gelic_wireless.c | 13 +++++--------
>> 1 files changed, 5 insertions(+), 8 deletions(-)
>
> Looks good, thanks.
>
> Acked-by: Geoff Levand <geoffrey.levand@am.sony.com>
Sorry, this is now a NAK.
Some PS3 driver clean-ups were merged, and Andy's change
is no longer needed. Here is the commit:
c1596b75c29eb5b32c65ef1e186c8b08c289bf05 - ps3_gelic_wireless: Remove PS3 gelic legacy wpa support
Sorry for asking for an updated patch when this
other change was queued.
-Geoff
next prev parent reply other threads:[~2010-03-03 22:13 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-22 18:08 [PATCH 00/11] Introduce common hex_to_bin() helper Andy Shevchenko
2010-02-22 18:09 ` [PATCH 01/11] lib: introduce common method to convert hex digits Andy Shevchenko
2010-03-09 1:03 ` Andy Shevchenko
2010-03-09 19:57 ` Andrew Morton
2010-04-22 8:39 ` Andy Shevchenko
2010-04-29 22:11 ` Andrew Morton
2010-02-22 18:09 ` [PATCH 02/11] drivers: isdn: use new hex_to_bin() method Andy Shevchenko
2010-02-22 21:22 ` Tilman Schmidt
2010-02-22 18:09 ` [PATCH 03/11] drivers: net: optimize hex2bin() Andy Shevchenko
2010-03-01 23:06 ` Geoff Levand
2010-03-02 7:59 ` [PATCHv2] " Andy Shevchenko
2010-03-02 16:04 ` Geoff Levand
2010-03-03 22:02 ` Geoff Levand [this message]
2010-02-22 18:09 ` [PATCH 04/11] usb: atm: speedtch: use new hex_to_bin() method Andy Shevchenko
2010-02-22 18:09 ` [PATCH 05/11] drivers: net: " Andy Shevchenko
2010-02-22 18:09 ` [PATCH 06/11] " Andy Shevchenko
2010-02-22 18:09 ` [PATCH 07/11] sysctl: don't use own implementation of hex_to_bin() Andy Shevchenko
2010-02-22 18:09 ` [PATCH 08/11] staging: rt2860: use new hex_to_bin() method Andy Shevchenko
2010-02-22 18:09 ` [PATCH 09/11] fs: ldm: don't use own implementation of hex_to_bin() Andy Shevchenko
2010-02-22 18:09 ` [PATCH 10/11] drivers: wireless: use new hex_to_bin() method Andy Shevchenko
2010-02-22 18:09 ` [PATCH 11/11] drivers: acpi: don't use own implementation of hex_to_bin() Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B8EDC86.20806@am.sony.com \
--to=geoffrey.levand@am.sony.com \
--cc=andy.shevchenko@gmail.com \
--cc=ext-andriy.shevchenko@nokia.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.