From: Benoit PAPILLAULT <benoit.papillault@free.fr>
To: Andrew Blaich <ablaich@gmail.com>
Cc: "John W. Linville" <linville@tuxdriver.com>,
linux-wireless@vger.kernel.org, Jiri Slaby <jirislaby@gmail.com>,
Nick Kossifidis <mickflemm@gmail.com>,
"Luis R. Rodriguez" <lrodriguez@atheros.com>,
Bob Copeland <me@bobcopeland.com>
Subject: Re: [PATCH] ath5k: fixing retries in ath5k_hw_setup_4word_tx_desc
Date: Wed, 03 Mar 2010 23:03:46 +0100 [thread overview]
Message-ID: <4B8EDCC2.9070401@free.fr> (raw)
In-Reply-To: <6b5e31691003010730ie73ff4cld32e3a9d38def7d0@mail.gmail.com>
Andrew Blaich a écrit :
> This Patch:
>
> The rate control algorithm, default is Minstrel for ath5k, determines
> the number of retries to use for each rate. However, there exists in
> ath5k_hw_setup_4word_tx_desc (which is called for AR5212 like devices)
> a set number of retries defined by AR5K_TUNE_HWTXTRIES. The set
> number of tries is added to the tx_tries0 variable setup by the rate
> control algorithm. This changes the number of retries the rate
> control algorithm considers necessary. By removing the
> AR5K_TUNE_HWTXTRIES from the retry calculation the rate control
> algorithm is given control over the number of retries.
>
>
> Signed-off-by:: Andrew Blaich <ablaich@gmail.com>
> ---
> diff --git a/drivers/net/wireless/ath/ath5k/desc.c
> b/drivers/net/wireless/ath/ath5k/desc.c
> index dc30a2b..c18d8d4 100644
> --- a/drivers/net/wireless/ath/ath5k/desc.c
> +++ b/drivers/net/wireless/ath/ath5k/desc.c
> @@ -229,7 +229,7 @@ static int ath5k_hw_setup_4word_tx_desc(struct ath5k_hw *ah,
> AR5K_REG_SM(antenna_mode, AR5K_4W_TX_DESC_CTL0_ANT_MODE_XMIT);
> tx_ctl->tx_control_1 |= AR5K_REG_SM(type,
> AR5K_4W_TX_DESC_CTL1_FRAME_TYPE);
> - tx_ctl->tx_control_2 = AR5K_REG_SM(tx_tries0 + AR5K_TUNE_HWTXTRIES,
> + tx_ctl->tx_control_2 = AR5K_REG_SM(tx_tries0,
> AR5K_4W_TX_DESC_CTL2_XMIT_TRIES0);
> tx_ctl->tx_control_3 = tx_rate0 & AR5K_4W_TX_DESC_CTL3_XMIT_RATE0;
> --
> To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
>
Good catch. If I were you, I would remove the #define in ath5.h as well
since it is no longer use.
Tested & Acked-by: Benoit Papillault <benoit.papillault@free.fr>
Regards,
Benoit
next prev parent reply other threads:[~2010-03-03 22:03 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-01 15:30 [PATCH] ath5k: fixing retries in ath5k_hw_setup_4word_tx_desc Andrew Blaich
2010-03-03 22:03 ` Benoit PAPILLAULT [this message]
2010-03-03 23:30 ` Bob Copeland
2010-03-04 14:21 ` Andrew Blaich
2010-03-05 13:15 ` Bob Copeland
2010-03-15 19:50 ` Andrew Blaich
2010-03-15 19:54 ` Andrew Blaich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B8EDCC2.9070401@free.fr \
--to=benoit.papillault@free.fr \
--cc=ablaich@gmail.com \
--cc=jirislaby@gmail.com \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=lrodriguez@atheros.com \
--cc=me@bobcopeland.com \
--cc=mickflemm@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.