From: Frederic Crozat <fcrozat@mandriva.com>
To: linux-hotplug@vger.kernel.org
Subject: Re: ACL_MANAGE meaning in udev is inconsistent
Date: Thu, 04 Mar 2010 08:40:58 +0000 [thread overview]
Message-ID: <4B8F721A.2@mandriva.com> (raw)
In-Reply-To: <e4eb41061002182237mc53a581haced9dc06598be2f@mail.gmail.com>
Le 04/03/2010 01:33, Kay Sievers a écrit :
> 2010/3/3 Martin Pitt<martin.pitt@ubuntu.com>:
>> Rafał Rzepecki [2010-02-19 7:37 +0100]:
>>> In extras/udev-acl/70-acl.rules:4 ACL_MANAGE is tested for zeroness to check
>>> whether a device should be excluded from ACL management:
>>>
>>> ENV{ACL_MANAGE}="0", GOTO="acl_end"
>>>
>>> This is not consistent with usage in extras/udev-acl/udev-acl.c:292:
>>
>> Thanks for catching this! Fixed in
>>
>> http://git.kernel.org/?p=linux/hotplug/udev.git;a=commitdiff;h\3ebbf35a2c101e0212c7066f0d65e457fcf40c
>
> I'll remove that later on. Please do not rely on this functionality.
> The ACL_MANAGE key must not leak to any other rules file. We will
> likely change that name to be able to speed things up, and nothing
> should use it outside the acl rules file.
Hmm, this is problematic : a lot of rules outside udev are using
ACL_MANAGE to specify ACL should be set for some devices. I would
suggest to not "deprecate" ACL_MANAGE outside 70-acl.rules but
internally to 70-acl.rules, use another variable.
--
Frederic Crozat
Mandriva
next prev parent reply other threads:[~2010-03-04 8:40 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-19 6:37 ACL_MANAGE meaning in udev is inconsistent Rafał Rzepecki
2010-03-03 23:51 ` Martin Pitt
2010-03-04 0:33 ` Kay Sievers
2010-03-04 8:40 ` Frederic Crozat [this message]
2010-03-04 9:26 ` Martin Pitt
2010-03-04 9:54 ` Frederic Crozat
2010-03-04 19:15 ` Kay Sievers
2010-03-04 19:23 ` Kay Sievers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B8F721A.2@mandriva.com \
--to=fcrozat@mandriva.com \
--cc=linux-hotplug@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.