From: Jeff Garzik <jeff@garzik.org>
To: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Cc: davem@davemloft.net, netdev@vger.kernel.org, gospo@redhat.com
Subject: Re: [PATCH v4] ethtool: Add direct access to ops->get_sset_count
Date: Thu, 04 Mar 2010 08:23:05 -0500 [thread overview]
Message-ID: <4B8FB439.8050901@garzik.org> (raw)
In-Reply-To: <20100304085054.4471.44679.stgit@localhost.localdomain>
On 03/04/2010 03:51 AM, Jeff Kirsher wrote:
> From: Jeff Garzik<jgarzik@redhat.com>
>
> This patch is an alternative approach for accessing string
> counts, vs. the drvinfo indirect approach. This way the drvinfo
> space doesn't run out, and we don't break ABI later.
>
> Signed-off-by: Jeff Garzik<jgarzik@redhat.com>
> Signed-off-by: Peter P Waskiewicz Jr<peter.p.waskiewicz.jr@intel.com>
> Signed-off-by: Jeff Kirsher<jeffrey.t.kirsher@intel.com>
> ---
>
> include/linux/ethtool.h | 17 +++++++++--
> net/core/ethtool.c | 72 +++++++++++++++++++++++++++++++++++++++++++++++
> 2 files changed, 86 insertions(+), 3 deletions(-)
Both patches look good to me. There is a cosmetic issue of needing to
sync up userspace and kernel ethtool.h WRT whitespace and deleted
constants, but I can do that after DaveM applies this patch.
Waiting for upstream application, or other objections...
next prev parent reply other threads:[~2010-03-04 13:23 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-04 8:51 [PATCH v4] ethtool: Add direct access to ops->get_sset_count Jeff Kirsher
2010-03-04 13:23 ` Jeff Garzik [this message]
2010-03-05 22:00 ` David Miller
2010-03-04 14:26 ` Ben Hutchings
2010-03-04 18:21 ` [PATCH] " Jeff Garzik
2010-03-05 22:00 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B8FB439.8050901@garzik.org \
--to=jeff@garzik.org \
--cc=davem@davemloft.net \
--cc=gospo@redhat.com \
--cc=jeffrey.t.kirsher@intel.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.