From mboxrd@z Thu Jan 1 00:00:00 1970 From: Anthony Liguori Subject: Re: [PATCH 08/10] Add -kvm option Date: Thu, 04 Mar 2010 13:41:39 -0600 Message-ID: <4B900CF3.7070400@codemonkey.ws> References: <1267215141-13629-1-git-send-email-glommer@redhat.com> <1267215141-13629-2-git-send-email-glommer@redhat.com> <1267215141-13629-3-git-send-email-glommer@redhat.com> <1267215141-13629-4-git-send-email-glommer@redhat.com> <1267215141-13629-5-git-send-email-glommer@redhat.com> <1267215141-13629-6-git-send-email-glommer@redhat.com> <1267215141-13629-7-git-send-email-glommer@redhat.com> <1267215141-13629-8-git-send-email-glommer@redhat.com> <1267215141-13629-9-git-send-email-glommer@redhat.com> <20100302043105.GB11510@amt.cnet> <20100302182558.GC665@mothafucka.localdomain> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit To: Glauber Costa , kvm-devel , Marcelo Tosatti Return-path: Received: from ey-out-2122.google.com ([74.125.78.27]:56441 "EHLO ey-out-2122.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932121Ab0CDTlr (ORCPT ); Thu, 4 Mar 2010 14:41:47 -0500 Received: by ey-out-2122.google.com with SMTP id 25so498323eya.19 for ; Thu, 04 Mar 2010 11:41:44 -0800 (PST) In-Reply-To: <20100302182558.GC665@mothafucka.localdomain> Sender: kvm-owner@vger.kernel.org List-ID: On 03/02/2010 12:25 PM, Glauber Costa wrote: > On Tue, Mar 02, 2010 at 01:31:05AM -0300, Marcelo Tosatti wrote: > >> On Fri, Feb 26, 2010 at 05:12:19PM -0300, Glauber Costa wrote: >> >>> This option deprecates --enable-kvm. It is a more flexible option, >>> that makes use of qemu-opts, and allow us to pass on options to enable or >>> disable kernel irqchip, for example. >>> >>> Signed-off-by: Glauber Costa >>> >> Really have to replace -enable-kvm? Can't you keep compatibility for it? >> > We don't have to , but I'd rather deprecate it. I don't feel strongly, though. > It needs to stay. For enabling/disabling, if you don't like -enable-kvm, I'd suggest thinking about modeling it through CPU. For instance: -cpu host,accel=kvm|tcg|kvm,tcg Since we already specify CPU's in a global config, if you took this approach, it would make it possible to tweak the default kvm vs. tcg selection within the config file so a user could control whether vms were created with tcg or kvm by default or whether it tried kvm and then fell back to tcg. Regards, Anthony Liguori > -- > To unsubscribe from this list: send the line "unsubscribe kvm" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html >