From: Kevin Wolf <kwolf@redhat.com>
To: Christoph Hellwig <hch@lst.de>
Cc: Christian Borntraeger <borntraeger@de.ibm.com>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] block: add logical_block_size property
Date: Fri, 05 Mar 2010 10:55:52 +0100 [thread overview]
Message-ID: <4B90D528.3060901@redhat.com> (raw)
In-Reply-To: <20100305093224.GA7148@lst.de>
Am 05.03.2010 10:32, schrieb Christoph Hellwig:
> On Fri, Mar 05, 2010 at 10:26:21AM +0100, Kevin Wolf wrote:
>> Is there a check anywhere that the user didn't give us an odd block
>> size? We could get an interesting bit mask otherwise.
>
> Not yet. I used to have such a check in the first incarnation of
> the block topology patches, but I have no idea how to do it in a
> centralized way using the qdev attributs.
>
> Does anyone know if there's a better way to do this than just
> duplicating the check in every driver?
We could probably introduce a new qdev property type that says "unsigned
16 bit integer, but only powers of two", and doing this looks quite
easy. On the other hand, having a new type for each possible restriction
sounds a bit silly...
Kevin
next prev parent reply other threads:[~2010-03-05 9:56 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-04 13:20 [Qemu-devel] [PATCH] block: add logical_block_size property Christoph Hellwig
2010-03-04 14:38 ` [Qemu-devel] " Christian Borntraeger
2010-03-05 9:26 ` [Qemu-devel] " Kevin Wolf
2010-03-05 9:32 ` Christoph Hellwig
2010-03-05 9:55 ` Kevin Wolf [this message]
2010-03-16 9:23 ` Christoph Hellwig
2010-03-17 9:59 ` [Qemu-devel] " Christian Borntraeger
2010-03-17 15:59 ` [Qemu-devel] " Anthony Liguori
2010-05-03 17:29 ` Artyom Tarasenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B90D528.3060901@redhat.com \
--to=kwolf@redhat.com \
--cc=borntraeger@de.ibm.com \
--cc=hch@lst.de \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.